All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaro Koskinen <aaro.koskinen@nokia.com>
To: "ext Woodruff, Richard" <r-woodruff2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP2: gptimer min_delta_ns should be rounded up
Date: Tue, 30 Dec 2008 18:50:45 +0200	[thread overview]
Message-ID: <495A5165.1040105@nokia.com> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE8967162036D3BCB12@dlee02.ent.ti.com>

Hello,

Woodruff, Richard wrote:
>> +             clockevent_delta2ns(1, &clockevent_gpt) + 1;
> 
> That value is still not correct.

[...]

>         clockevent_delta2ns(3, &clockevent_gpt);
> 
> min_delta_ns stops the frame work from trying to program an expiry time which may not be achievable due to timer costs.
> 
> A write to the timer when it has a 32KHz F-Clock can take ~3 32Khz clock cycles to complete.  Hence the cost of '3' not '1'.

I'm not sure if I see any problem. If the timer programming cost is 
bigger than min_delta_ns, the framework should adapt to it.

I guess you would want to make min_delta_ns bigger to avoid excessive 
scheduling/wakeups, but I think there is no any single "correct" value 
for every system/board.

A.

  reply	other threads:[~2008-12-30 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29 17:14 [PATCH] OMAP2: gptimer min_delta_ns should be rounded up Aaro Koskinen
2008-12-29 17:38 ` Woodruff, Richard
2008-12-30 16:50   ` Aaro Koskinen [this message]
2008-12-30 17:01     ` Woodruff, Richard
2008-12-31 15:22       ` Aaro Koskinen
2008-12-31 15:47         ` Woodruff, Richard
2009-01-05  4:57           ` Paul Walmsley
2009-01-09  4:41             ` Woodruff, Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495A5165.1040105@nokia.com \
    --to=aaro.koskinen@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.