All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Du <duyuyang@gmail.com>
To: linux-btrace@vger.kernel.org
Subject: Re: Re: Re: [PATCH] blktrace: fix to trace a partition, instead of
Date: Wed, 31 Dec 2008 02:21:43 +0000	[thread overview]
Message-ID: <495AD737.1010503@gmail.com> (raw)
In-Reply-To: <494895E9.9030300@gmail.com>

>Very nice! The only problem with this is that we have actions that are,
>by definition, per device. So we probably want to include any sector
>that is within the range of the partition, AND a zero sector. So that
>means changing act_log_check() to something ala:
>
>-       if (sector < bt->start_lba || sector > bt->end_lba)
>+       if (!sector || sector < bt->start_lba || sector > bt->end_lba)
>                return 1;
>
>in pseudo patch form.

Thank you sir. And perhaps, we change in __blk_add_trace():

-	if (unlikely(act_log_check(bt, what, sector, pid)))
+	if (act_log_check(bt, what, sector, pid))

Sorry for the lateness.

Happy New Year.

Shawn


  parent reply	other threads:[~2008-12-31  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17  6:02 [PATCH] blktrace: fix to trace a partition, instead of only disk Shawn Du
2008-12-17  8:01 ` Jens Axboe
2008-12-31  2:21 ` Shawn Du [this message]
2009-01-05  9:18 ` Re: " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495AD737.1010503@gmail.com \
    --to=duyuyang@gmail.com \
    --cc=linux-btrace@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.