From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag
Date: Tue, 30 Dec 2008 20:55:41 -0600 [thread overview]
Message-ID: <495ADF2D.8050709@sandeen.net> (raw)
In-Reply-To: <20081230230913.302710000@bombadil.infradead.org>
Christoph Hellwig wrote:
> Based on http://oss.sgi.com/bugzilla/show_bug.cgi?id=340.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests/195
...
> +_do_dump()
> +{
> + xfsdump -l 0 -s d -F \
> + -L prova -M prova \
> + -f $TEST_DIR/dumpfile -e -v excluded_files=debug $TEST_DIR \
> + | grep "ino $inum" \
> + | sed -e 's/xfsdump: pruned ino [0-9]*, owner 0, estimated size 0: skip flag set/xfsdump: pruned ino NNN, owner 0, estimated size 0: skip flag set/'
> +}
That's a bigger pattern than I'd have matched but as far as bike sheds
go, looks good to me :)
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-31 2:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081230230810.986105000@bombadil.infradead.org>
2008-12-30 23:08 ` [PATCH 1/5] xfstests: fix compiler warnings Christoph Hellwig
2008-12-31 1:59 ` Eric Sandeen
2008-12-31 9:30 ` Christoph Hellwig
2008-12-31 12:08 ` Christoph Hellwig
2008-12-30 23:08 ` [PATCH 2/5] xfstests: update for xfs_dinode_core_t removal Christoph Hellwig
2008-12-31 2:08 ` Eric Sandeen
2008-12-30 23:08 ` [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag Christoph Hellwig
2008-12-31 2:55 ` Eric Sandeen [this message]
2008-12-30 23:08 ` [PATCH 4/5] xfstests: test 196, add a testcase for renames across project boundaries Christoph Hellwig
2008-12-31 3:36 ` Eric Sandeen
2008-12-30 23:08 ` [PATCH 5/5] xfstests: test 197, add a testcase for d_off truncation Christoph Hellwig
2008-12-31 4:00 ` Eric Sandeen
2008-12-31 9:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495ADF2D.8050709@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.