All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Guennadi Liakhovetski <lg@denx.de>
Subject: [PATCH mmotm] leds-dac124s085: use header files for interfaces
Date: Tue, 30 Dec 2008 22:26:15 -0800	[thread overview]
Message-ID: <495B1087.3070205@oracle.com> (raw)
In-Reply-To: <200812310006.mBV060iV029753@imap1.linux-foundation.org>

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix build errors caused by not using #includes for interfaces that are used:

drivers/leds/leds-dac124s085.c: In function 'dac124s085_probe':
drivers/leds/leds-dac124s085.c:70: error: 'GFP_KERNEL' undeclared (first use in this function)
drivers/leds/leds-dac124s085.c:70: warning: assignment makes pointer from integer without a cast
drivers/leds/leds-dac124s085.c: At top level:
drivers/leds/leds-dac124s085.c:127: error: field name not in record or union initializer
drivers/leds/leds-dac124s085.c:127: error: (near initialization for 'dac124s085_driver.driver')
drivers/leds/leds-dac124s085.c:128: error: field name not in record or union initializer
drivers/leds/leds-dac124s085.c:128: error: (near initialization for 'dac124s085_driver.driver')
drivers/leds/leds-dac124s085.c:128: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/leds/leds-dac124s085.c:145: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:145: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:145: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/leds/leds-dac124s085.c:145: warning: function declaration isn't a prototype
drivers/leds/leds-dac124s085.c:146: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:146: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:146: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/leds/leds-dac124s085.c:146: warning: function declaration isn't a prototype
drivers/leds/leds-dac124s085.c:147: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:147: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:147: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/leds/leds-dac124s085.c:147: warning: function declaration isn't a prototype

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Guennadi Liakhovetski <lg@denx.de>
---
 drivers/leds/leds-dac124s085.c |    3 +++
 1 file changed, 3 insertions(+)

--- mmotm-2008-1230-1605.orig/drivers/leds/leds-dac124s085.c
+++ mmotm-2008-1230-1605/drivers/leds/leds-dac124s085.c
@@ -9,8 +9,11 @@
  * LED driver for the DAC124S085 SPI DAC
  */
 
+#include <linux/gfp.h>
 #include <linux/leds.h>
+#include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
 #include <linux/spi/spi.h>

  parent reply	other threads:[~2008-12-31  6:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31  0:06 mmotm 2008-12-30-16-05 uploaded akpm
2008-12-31  3:51 ` mmotm 2008-12-30-16-05 uploaded (mtd) Randy Dunlap
2008-12-31  3:59 ` mmotm 2008-12-30-16-05 uploaded (mmc) Randy Dunlap
2008-12-31 18:07   ` Pierre Ossman
2008-12-31 18:48     ` Rafael J. Wysocki
2008-12-31  4:07 ` [PATCH mmotm] input: fix function arg list Randy Dunlap
2008-12-31  4:21 ` [PATCH] spi.h uses/needs device.h Randy Dunlap
2009-01-01 21:58   ` Guennadi Liakhovetski
2008-12-31  6:26 ` Randy Dunlap [this message]
2008-12-31 14:42 ` [PATCH for mmotm1230] acpi: fix unused variable warnings KOSAKI Motohiro
2008-12-31 14:45 ` [PATCH for mmotm1230] input: fix incomplete prototype of input_init_abs_bypass() KOSAKI Motohiro
2009-01-01  1:51 ` [mmotm 2008-12-30-16-05] Warning at MPT driver initialization Tetsuo Handa
2009-01-01  2:26   ` Andrew Morton
2009-01-05 16:45     ` Eric Paris
2009-01-12 22:19       ` Andrew Morton
2009-01-01 20:51 ` mmotm 2008-12-30-16-05 uploaded Valdis.Kletnieks
2009-01-02  2:31   ` Andrew Morton
2009-01-02  2:42     ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495B1087.3070205@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=lg@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.