From: Robert Reif <reif@earthlink.net>
To: sparclinux@vger.kernel.org
Subject: Re: [RFC PATCH] use sparc64 version of of_device.c
Date: Thu, 01 Jan 2009 07:10:39 +0000 [thread overview]
Message-ID: <495C6C6F.2030803@earthlink.net> (raw)
In-Reply-To: <4945AE56.2040503@earthlink.net>
Sam Ravnborg wrote:
>> +#ifdef CONFIG_SPARC64
>> void __iomem *of_ioremap(struct resource *res, unsigned long offset, unsigned long size, char *name)
>> {
>> unsigned long ret = res->start + offset;
>> @@ -34,6 +35,7 @@ void of_iounmap(struct resource *res, void __iomem *base, unsigned long size)
>> release_region((unsigned long) base, size);
>> }
>> EXPORT_SYMBOL(of_iounmap);
>> +#endif
>>
>
> For sparc32 we have these in ioport.c.
> So the better alternative would maybe have been to move them
> to a ioport_64 file?
>
Wouldn't it be better to use these in sparc32? This would require
using 64 bit resources. We could then use generic code. This and
switching to bootmem allocations in irq.c would eliminate a good
chunk of ioport.c by using generic or shared code.
prev parent reply other threads:[~2009-01-01 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 1:09 [RFC PATCH] use sparc64 version of of_device.c Robert Reif
2008-12-15 18:52 ` Sam Ravnborg
2008-12-15 22:52 ` David Miller
2008-12-15 22:57 ` Julian Calaby
2008-12-21 20:47 ` Sam Ravnborg
2009-01-01 7:10 ` Robert Reif [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495C6C6F.2030803@earthlink.net \
--to=reif@earthlink.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.