From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Cc: gorcunov@gmail.com, Cyrill Gorcunov <gorcunov@openvz.org>,
Len Brown <lenb@kernel.org>
Subject: [patch 3/3] acpi: check for pxm_to_node_map overflow
Date: Fri, 02 Jan 2009 11:27:20 +0300 [thread overview]
Message-ID: <495dd169.0437560a.1cd3.ffffd503@mx.google.com> (raw)
In-Reply-To: 20090102082717.810810508@gmail.com
[-- Attachment #1: x86-acpi-pxm-overflow --]
[-- Type: text/plain, Size: 786 bytes --]
It is hardly (if ever) possible but in case of broken _PXM
entry we could reach out of pxm_to_node_map array
bounds in acpi_map_pxm_to_node() call. Lets check it
(it's not that expensive and safe).
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
CC: Len Brown <lenb@kernel.org>
---
drivers/acpi/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/drivers/acpi/numa.c
===================================================================
--- linux-2.6.git.orig/drivers/acpi/numa.c
+++ linux-2.6.git/drivers/acpi/numa.c
@@ -278,7 +278,7 @@ int acpi_get_node(acpi_handle *handle)
int pxm, node = -1;
pxm = acpi_get_pxm(handle);
- if (pxm >= 0)
+ if (pxm >= 0 && pxm < MAX_PXM_DOMAINS)
node = acpi_map_pxm_to_node(pxm);
return node;
--
next prev parent reply other threads:[~2009-01-02 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090102082717.810810508@gmail.com>
2009-01-02 8:27 ` [patch 1/3] early_printk - use sizeof instead of hardcoded number Cyrill Gorcunov
2009-01-02 8:27 ` [patch 2/3] mm: hugetlb -- get rid of redundant if operation Cyrill Gorcunov
2009-01-02 9:22 ` Ingo Molnar
2009-01-02 8:27 ` Cyrill Gorcunov [this message]
2009-01-02 9:23 ` [patch 3/3] acpi: check for pxm_to_node_map overflow Ingo Molnar
2009-01-02 10:25 ` Cyrill Gorcunov
2009-01-02 10:30 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495dd169.0437560a.1cd3.ffffd503@mx.google.com \
--to=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.