From: ib@wupperonline.de (Ingo Brueckl)
To: Ingo Molnar <mingo@elte.hu>
Cc: Jesper Juhl <jj@chaosbits.net>
Cc: Tom Spink <tspink@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] compile time warnings
Date: Fri, 02 Jan 2009 13:53:00 +0100 [thread overview]
Message-ID: <495e0d52@wupperonline.de> (raw)
In-Reply-To: <20090102095727.GH1975@elte.hu>
Ingo Molnar <mingo@elte.hu> writes:
> Would you mind to send a patch for that that we could push to Linus?
Do you mean something like:
fix compiler warning in arch/x86/mm/init_32.c
Signed-off-by: Ingo Brueckl <ib@wupperonline.de>
--- linux-2.6.28/arch/x86/mm/init_32.c.orig 2008-12-25 00:26:37.000000000 +0100
+++ linux-2.6.28/arch/x86/mm/init_32.c 2009-01-02 12:51:17.000000000 +0100
@@ -436,8 +436,13 @@ static void __init set_highmem_pages_ini
#endif /* !CONFIG_NUMA */
#else
-# define permanent_kmaps_init(pgd_base) do { } while (0)
-# define set_highmem_pages_init() do { } while (0)
+static inline void permanent_kmaps_init(pgd_t *pgd_base)
+{
+ (void) pgd_base;
+}
+static inline void set_highmem_pages_init(void)
+{
+}
#endif /* CONFIG_HIGHMEM */
void __init native_pagetable_setup_start(pgd_t *base)
next prev parent reply other threads:[~2009-01-02 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 21:13 compile time warnings Ingo Brueckl
2009-01-01 22:52 ` Jesper Juhl
2009-01-02 1:35 ` Tom Spink
2009-01-02 1:39 ` Harvey Harrison
2009-01-02 2:07 ` Jesper Juhl
2009-01-02 9:57 ` Ingo Molnar
2009-01-02 12:53 ` Ingo Brueckl [this message]
2009-01-02 13:01 ` [PATCH] " Ingo Molnar
2009-01-02 13:42 ` Ingo Brueckl
2009-01-02 14:42 ` Ingo Molnar
2009-01-02 16:07 ` Jesper Juhl
2009-01-02 16:10 ` Jesper Juhl
2009-01-02 2:48 ` Ingo Brueckl
2009-01-02 20:03 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495e0d52@wupperonline.de \
--to=ib@wupperonline.de \
--cc=jj@chaosbits.net \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.