diff for duplicates of <49609AFE.2010209@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index adb387d..5c04b7d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,30 +1,40 @@ -Christoph Hellwig ?rta: +Christoph Hellwig =EDrta: > On Sat, Jan 03, 2009 at 02:44:17PM +0100, Gabor Juhos wrote: ->> +static dma_addr_t ath_ahb_map_single_to_device(struct ath_softc *sc, +>> +static dma_addr_t ath_ahb_map_single_to_device(struct ath_softc *sc= +, >> + void *p, size_t size) >> +{ >> + return dma_map_single(NULL, p, size, DMA_TO_DEVICE); >> +} -> -> As said before you should just use dma_* directly. And please make sure +>=20 +> As said before you should just use dma_* directly. And please make s= +ure > to always pass a struct device to the dma_* routines, even if your > platform might currently not required it the API does. -> +>=20 >> +static void ath_ahb_cleanup(struct ath_softc *sc) >> +{ ->> + struct platform_device *pdev = to_platform_device(sc->dev); ->> + struct ieee80211_hw *hw = sc->hw; +>> + struct platform_device *pdev =3D to_platform_device(sc->dev); +>> + struct ieee80211_hw *hw =3D sc->hw; >> + struct resource *res; >> + ->> + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); +>> + res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0); >> + if (res) >> + free_irq(res->start, sc); -> -> If you stored the irq value directly in the softc this whole thing might +>=20 +> If you stored the irq value directly in the softc this whole thing mi= +ght > be able to be done in a generic way.. -> -> +>=20 +>=20 -I did not want to store it in the softc, because 'struct pci_dev' has it already -and we will duplicate it. However the code will be simpler, so i can add it of +I did not want to store it in the softc, because 'struct pci_dev' has i= +t already +and we will duplicate it. However the code will be simpler, so i can ad= +d it of course. +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireles= +s" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 261aeee..9246d36 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,40 +2,57 @@ "ref\01230990262-22923-8-git-send-email-juhosg@openwrt.org\0" "ref\020090104073022.GC12905@infradead.org\0" "From\0Gabor Juhos <juhosg@openwrt.org>\0" - "Subject\0[ath9k-devel] [RFC 07/12] ath9k: introduce platform driver for AHB bus\tsupport\0" + "Subject\0Re: [RFC 07/12] ath9k: introduce platform driver for AHB bus\tsupport\0" "Date\0Sun, 04 Jan 2009 12:18:22 +0100\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Christoph Hellwig <hch@infradead.org>\0" + "Cc\0John W. Linville <linville@tuxdriver.com>" + Luis R. Rodriguez <lrodriguez@atheros.com> + Jouni Malinen <jmalinen@atheros.com> + ath9k-devel@lists.ath9k.org <ath9k-devel@venema.h4ckr.net> + linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> + Felix Fietkau <nbd@openwrt.org> + " Imre Kaloz <kaloz@openwrt.org>\0" "\00:1\0" "b\0" - "Christoph Hellwig ?rta:\n" + "Christoph Hellwig =EDrta:\n" "> On Sat, Jan 03, 2009 at 02:44:17PM +0100, Gabor Juhos wrote:\n" - ">> +static dma_addr_t ath_ahb_map_single_to_device(struct ath_softc *sc,\n" + ">> +static dma_addr_t ath_ahb_map_single_to_device(struct ath_softc *sc=\n" + ",\n" ">> +\t\t\t\t\t void *p, size_t size)\n" ">> +{\n" ">> +\treturn dma_map_single(NULL, p, size, DMA_TO_DEVICE);\n" ">> +}\n" - "> \n" - "> As said before you should just use dma_* directly. And please make sure\n" + ">=20\n" + "> As said before you should just use dma_* directly. And please make s=\n" + "ure\n" "> to always pass a struct device to the dma_* routines, even if your\n" "> platform might currently not required it the API does.\n" - "> \n" + ">=20\n" ">> +static void ath_ahb_cleanup(struct ath_softc *sc)\n" ">> +{\n" - ">> +\tstruct platform_device *pdev = to_platform_device(sc->dev);\n" - ">> +\tstruct ieee80211_hw *hw = sc->hw;\n" + ">> +\tstruct platform_device *pdev =3D to_platform_device(sc->dev);\n" + ">> +\tstruct ieee80211_hw *hw =3D sc->hw;\n" ">> +\tstruct resource *res;\n" ">> +\n" - ">> +\tres = platform_get_resource(pdev, IORESOURCE_IRQ, 0);\n" + ">> +\tres =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0);\n" ">> +\tif (res)\n" ">> +\t\tfree_irq(res->start, sc);\n" - "> \n" - "> If you stored the irq value directly in the softc this whole thing might\n" + ">=20\n" + "> If you stored the irq value directly in the softc this whole thing mi=\n" + "ght\n" "> be able to be done in a generic way..\n" - "> \n" - "> \n" + ">=20\n" + ">=20\n" "\n" - "I did not want to store it in the softc, because 'struct pci_dev' has it already\n" - "and we will duplicate it. However the code will be simpler, so i can add it of\n" - course. + "I did not want to store it in the softc, because 'struct pci_dev' has i=\n" + "t already\n" + "and we will duplicate it. However the code will be simpler, so i can ad=\n" + "d it of\n" + "course.\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" + "s\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -b8db5a19fd487de92e3f778ddf5bcfc9f4ff8e850402e06cf9e4a799ed6de23b +0317a4361bb1630896bf4dccf8b794f2aa5595a8c805241d16555ba94264bb0e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.