Re: [PATCH] scsi_lib: don't decrement busy counters when inserting commands

[Mike Christie <michaelc@cs.wisc.edu>]

James Bottomley wrote:
> On Tue, 2008-12-16 at 23:55 -0600, michaelc@cs.wisc.edu wrote:
>> From: Mike Christie <michaelc@cs.wisc.edu>
>>
>> This patch fixes a regression in scsi-misc introduced with:
>> 312efe5efcdb02d604ea37a41d965f32ca276d6a
>> [SCSI] simplify scsi_io_completion().
>>
>> The problem is that in previous kernels scsi_io_completion would call
>> scsi_requeue_command, but now it can call scsi_queue_insert for
>> something like a UNIT_ATTENTION (for netapp targets we get
>> UNIT_ATTENTION when restarting a iscsi session). And scsi_queue_insert
>> will call scsi_device_unbusy, but in the scsi_io_completion code path
>> scsi_finish_command has already called this so we now end up
>> with invalid host, target and device busy values.
>>
>> Patch was made over scsi-misc.
> 
> This is a bad bug, but not quite the way I'd like to fix it.  Whether
> the queue should be unbusied or not is really separate from the block
> action, so it should have its own flag (plus it's not really a flag many
> people should be using).  Since, really, the wrong use is confined to
> the defining file, how about this:
> 

Patch fixed my problem here. Thanks.