From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Ferruh Yigit" <ferruh.yigit@intel.com>
Cc: Jan Viktorin <viktorin@rehivetech.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Jerin Jacob <jerinj@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
dev@dpdk.org, Thierry Herbelot <thierry.herbelot@6wind.com>,
vcchunga@amazon.com
Subject: Re: [dpdk-dev] [PATCH v2] config/arm: fix variable name
Date: Tue, 02 Feb 2021 10:22:57 +0100 [thread overview]
Message-ID: <4961940.pjLH7HjvyZ@thomas> (raw)
In-Reply-To: <20210202083507.3252029-1-ferruh.yigit@intel.com>
02/02/2021 09:35, Ferruh Yigit:
> A config variable rename seems missed to update all config files and new
> config file get with old variable names.
>
> Reflect config variable rename to all config files, changed
> 'implementor_id' to 'implementer_id',
> 'implementor_pn' to 'part_number'.
>
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: 7870ae8994c6 ("config/arm: rename variables")
>
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Applied, thanks.
That's why I don't want to merge all the Arm build changes
as a batch in the same release.
Sometimes we need to have some steps.
prev parent reply other threads:[~2021-02-02 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 17:05 [dpdk-dev] Typos in Arm xconfig files Thierry Herbelot
2021-02-01 22:41 ` [dpdk-dev] [PATCH] config/arm: fix typo in meson config Ferruh Yigit
2021-02-01 23:22 ` Honnappa Nagarahalli
2021-02-02 2:19 ` Ruifeng Wang
2021-02-02 8:08 ` Ferruh Yigit
2021-02-02 7:12 ` Juraj Linkeš
2021-02-02 8:35 ` [dpdk-dev] [PATCH v2] config/arm: fix variable name Ferruh Yigit
2021-02-02 9:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4961940.pjLH7HjvyZ@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=ruifeng.wang@arm.com \
--cc=thierry.herbelot@6wind.com \
--cc=vcchunga@amazon.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.