From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: Interrupt mask notifiers for ioapic
Date: Mon, 05 Jan 2009 15:24:07 +0200 [thread overview]
Message-ID: <496209F7.6030007@redhat.com> (raw)
In-Reply-To: <200901051506.15661.sheng@linux.intel.com>
Sheng Yang wrote:
> On Monday 05 January 2009 00:14:44 Avi Kivity wrote:
>
>> Allow clients to request notifications when the guest masks or unmasks a
>> particular irq line. This complements irq ack notifications, as the guest
>> will not ack an irq line that is masked.
>>
>> Currently implemented for the ioapic only.
>>
>
> Hi Avi
>
> Need a lock for this list? Seems kvm_fire_mask_notifiers() implicit holding
> kvm->lock, but register/unregister didn't. And I think we need some comments
> for the necessary of lock.
>
Good catch. Everything in struct kvm is protected by kvm->lock (except
vcpus and the mmu... need a locking document). I added locking around
PIT creation so now registration is also protected (it also fixes a
potential leak if two threads try to create a PIT simultaneously).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-01-05 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 16:14 [PATCH 0/3] Reset PIT reinjection logic on irq unmask Avi Kivity
2009-01-04 16:14 ` [PATCH 1/3] KVM: Add CONFIG_HAVE_KVM_IRQCHIP Avi Kivity
2009-01-04 16:14 ` [PATCH 2/3] KVM: Interrupt mask notifiers for ioapic Avi Kivity
2009-01-05 7:06 ` Sheng Yang
2009-01-05 13:24 ` Avi Kivity [this message]
2009-01-05 18:29 ` Marcelo Tosatti
2009-01-05 20:57 ` Avi Kivity
2009-01-04 16:14 ` [PATCH 3/3] KVM: Reset PIT irq injection logic when the PIT IRQ is unmasked Avi Kivity
2009-01-05 18:31 ` Marcelo Tosatti
2009-01-05 20:59 ` Avi Kivity
2009-01-05 21:58 ` Marcelo Tosatti
2009-01-06 8:25 ` Avi Kivity
2009-01-06 9:35 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496209F7.6030007@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.