From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Date: Tue, 05 Apr 2016 19:03:55 +0300 Message-ID: <4962391.ZSHHxaj8ik@avalon> References: <2037371.nWufVmEmFd@avalon> <57039AE6.7050601@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57039AE6.7050601@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu Cc: tixy@linaro.org, mark.rutland@arm.com, alsa-devel@alsa-project.org, Alexey.Brodkin@synopsys.com, dri-devel@lists.freedesktop.org, lgirdwood@gmail.com, yitian.bu@tangramtek.com, wsa+renesas@sang-engineering.com, laurent.pinchart+renesas@ideasonboard.com, tiwai@suse.com, nariman@opensource.wolfsonmicro.com, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, Maruthi.Bayyavarapu@amd.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Vineet.Gupta1@synopsys.com, buyitian@gmail.com, robh+dt@kernel.org, perex@perex.cz, linux-kernel@vger.kernel.org, broonie@kernel.org, galak@codeaurora.org, alexander.deucher@amd.com, CARLOS.PALMINHA@synopsys.com List-Id: alsa-devel@alsa-project.org SGkgSm9zZSwKCk9uIFR1ZXNkYXkgMDUgQXByIDIwMTYgMTI6MDA6NTQgSm9zZSBBYnJldSB3cm90 ZToKPiBPbiAwNC0wNC0yMDE2IDIyOjQxLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24g TW9uZGF5IDA0IEFwciAyMDE2IDEwOjA1OjM5IEpvc2UgQWJyZXUgd3JvdGU6Cj4gPj4gT24gMDEt MDQtMjAxNiAxODoxMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4gT24gTW9uZGF5IDI4 IE1hciAyMDE2IDE1OjM2OjA5IEpvc2UgQWJyZXUgd3JvdGU6Cj4gPj4+PiBUaGlzIHBhdGNoIGFk ZHMgYXVkaW8gc3VwcG9ydCBmb3IgdGhlIEFEVjc1MTEgSERNSSB0cmFuc21pdHRlcgo+ID4+Pj4g dXNpbmcgQUxTQSBTb0MuCj4gPj4+PiAKPiA+Pj4+IFRoZSBjb2RlIHdhcyBwb3J0ZWQgZnJvbSBB bmFsb2cgRGV2aWNlcyBsaW51eCB0cmVlIGZyb20KPiA+Pj4+IGNvbW1pdCAxNzcwYzRhMWUzMmIg KCJNZXJnZSByZW1vdGUtdHJhY2tpbmcgYnJhbmNoCj4gPj4+PiAKPiA+Pj4+ICd4aWxpbngvbWFz dGVyJyBpbnRvIHhjb21tX3p5bnEiKSwgd2hpY2ggaXMgYXZhaWxhYmxlIGF0Ogo+ID4+Pj4gCS0g aHR0cHM6Ly9naXRodWIuY29tL2FuYWxvZ2RldmljZXNpbmMvbGludXgvCj4gPj4+PiAKPiA+Pj4+ IFRoZSBtYWluIGNvcmUgZmlsZSB3YXMgcmVuYW1lZCBmcm9tIGFkdjc1MTEuYyB0byBhZHY3NTEx X2NvcmUuYwo+ID4+Pj4gc28gdGhhdCBhdWRpbyBhbmQgdmlkZW8gY29tcGlsZSBpbnRvIGEgc2lu Z2xlIGFkdjc1MTEua28gbW9kdWxlCj4gPj4+PiBhbmQgdG8ga2VlcCB1cCB3aXRoIEFuYWxvZyBE ZXZpY2VzIGtlcm5lbCB0cmVlLgo+ID4+Pj4gCj4gPj4+PiBUaGUgYXVkaW8gY2FuIGJlIGRpc2Fi bGVkIHVzaW5nIG1lbnUtY29uZmlnIHNvIGl0IGlzIHBvc3NpYmxlCj4gPj4+PiB0byB1c2Ugb25s eSB2aWRlbyBtb2RlLgo+ID4+Pj4gCj4gPj4+PiBUaGUgSERNSSBtb2RlIGlzIGF1dG9tYXRpY2Fs bHkgc3RhcnRlZCBhdCBib290IGFuZCB0aGUgYXVkaW8KPiA+Pj4+ICh3aGVuIGVuYWJsZWQpIHJl Z2lzdGVycyBhcyBhIGNvZGVjIGludG8gQUxTQS4KPiA+Pj4+IAo+ID4+Pj4gU1BESUYgREFJIGZv cm1hdCB3YXMgYWxzbyBhZGRlZCB0byBBU29DIGFzIGl0IGlzIHJlcXVpcmVkCj4gPj4+PiBieSBh ZHY3NTExIGF1ZGlvLgo+ID4+Pj4gCj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBKb3NlIEFicmV1IDxq b2FicmV1QHN5bm9wc3lzLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gCj4gPj4+PiBObyBjaGFuZ2Vz IHYxIC0+IHYyLgo+ID4+Pj4gCj4gPj4+PiAgZHJpdmVycy9ncHUvZHJtL2kyYy9LY29uZmlnICAg ICAgICAgfCAgIDExICsKPiA+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTJjL01ha2VmaWxlICAgICAg ICB8ICAgIDIgKwo+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jICAgICAgIHwg MTAyNAo+ID4+Pj4gIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+Pj4+ICBkcml2ZXJz L2dwdS9kcm0vaTJjL2Fkdjc1MTEuaCAgICAgICB8ICAgNDEgKysKPiA+Pj4+ICBkcml2ZXJzL2dw dS9kcm0vaTJjL2Fkdjc1MTFfYXVkaW8uYyB8ICAzMTAgKysrKysrKysrKysKPiA+Pj4+ICBkcml2 ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTFfY29yZS5jICB8IDEwMDUKPiA+Pj4+ICArKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gPj4+IAo+ID4+PiBQbGVhc2UgdXNlIGdpdC1mb3JtYXQtcGF0 Y2ggLU0gdG8gZGV0ZWN0IHJlbmFtZXMgaWYgeW91IHNlbmQgYSBuZXcKPiA+Pj4gdmVyc2lvbgo+ ID4+PiBvZiB0aGlzIHNlcmllcywgaXQgd2lsbCBoZWxwIHdpdGggcmV2aWV3Lgo+ID4+IAo+ID4+ IE9rLCB3aWxsIGRvIHRoYXQgaW4gbmV4dCB2ZXJzaW9uLgo+ID4+IAo+ID4+Pj4gIGluY2x1ZGUv c291bmQvc29jLWRhaS5oICAgICAgICAgICAgIHwgICAgMSArCj4gPj4+PiAgNyBmaWxlcyBjaGFu Z2VkLCAxMzcwIGluc2VydGlvbnMoKyksIDEwMjQgZGVsZXRpb25zKC0pCj4gPj4+PiAgZGVsZXRl IG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jCj4gPj4+PiAgY3JlYXRl IG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMV9hdWRpby5jCj4gPj4+PiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMV9jb3JlLmMKPiA+ Pj4gCj4gPj4+IFtzbmlwXQo+ID4+PiAKPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTJjL2Fkdjc1MTFfY29yZS5jCj4gPj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUx MV9jb3JlLmMgbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+Pj4+IGluZGV4IDAwMDAwMDAuLmQ1NDI1 NmEKPiA+Pj4+IC0tLSAvZGV2L251bGwKPiA+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMv YWR2NzUxMV9jb3JlLmMKPiA+Pj4gCj4gPj4+IFtzbmlwXQo+ID4+PiAKPiA+Pj4+ICtzdGF0aWMg aW50IGFkdjc1MTFfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmkyYywgY29uc3Qgc3RydWN0Cj4g Pj4+PiBpMmNfZGV2aWNlX2lkICppZCkgK3sKPiA+Pj4+ICsJc3RydWN0IGFkdjc1MTFfbGlua19j b25maWcgbGlua19jb25maWc7Cj4gPj4+PiArCXN0cnVjdCBhZHY3NTExICphZHY3NTExOwo+ID4+ Pj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmaTJjLT5kZXY7Cj4gPj4+PiArCXVuc2lnbmVkIGlu dCB2YWw7Cj4gPj4+PiArCWludCByZXQ7Cj4gPj4+PiArCj4gPj4+PiArCWlmICghZGV2LT5vZl9u b2RlKQo+ID4+Pj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPj4+PiArCj4gPj4+PiArCWFkdjc1MTEg PSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmFkdjc1MTEpLCBHRlBfS0VSTkVMKTsKPiA+Pj4+ ICsJaWYgKCFhZHY3NTExKQo+ID4+Pj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gPj4+PiArCj4gPj4+ PiArCWFkdjc1MTEtPnBvd2VyZWQgPSBmYWxzZTsKPiA+Pj4+ICsJYWR2NzUxMS0+c3RhdHVzID0g Y29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4gPj4+PiArCj4gPj4+PiArCXJldCA9IGFk djc1MTFfcGFyc2VfZHQoZGV2LT5vZl9ub2RlLCAmbGlua19jb25maWcpOwo+ID4+Pj4gKwlpZiAo cmV0KQo+ID4+Pj4gKwkJcmV0dXJuIHJldDsKPiA+Pj4+ICsKPiA+Pj4+ICsJLyoKPiA+Pj4+ICsJ ICogVGhlIHBvd2VyIGRvd24gR1BJTyBpcyBvcHRpb25hbC4gSWYgcHJlc2VudCwgdG9nZ2xlIGl0 IGZyb20gYWN0aXZlCj4gPj4+PiB0bwo+ID4+Pj4gKwkgKiBpbmFjdGl2ZSB0byB3YWtlIHVwIHRo ZSBlbmNvZGVyLgo+ID4+Pj4gKwkgKi8KPiA+Pj4+ICsJYWR2NzUxMS0+Z3Bpb19wZCA9IGRldm1f Z3Bpb2RfZ2V0X29wdGlvbmFsKGRldiwgInBkIiwKPiA+IAo+ID4gR1BJT0RfT1VUX0hJR0gpOwo+ ID4gCj4gPj4+PiArCWlmIChJU19FUlIoYWR2NzUxMS0+Z3Bpb19wZCkpCj4gPj4+PiArCQlyZXR1 cm4gUFRSX0VSUihhZHY3NTExLT5ncGlvX3BkKTsKPiA+Pj4+ICsKPiA+Pj4+ICsJaWYgKGFkdjc1 MTEtPmdwaW9fcGQpIHsKPiA+Pj4+ICsJCW1kZWxheSg1KTsKPiA+Pj4+ICsJCWdwaW9kX3NldF92 YWx1ZV9jYW5zbGVlcChhZHY3NTExLT5ncGlvX3BkLCAwKTsKPiA+Pj4+ICsJfQo+ID4+Pj4gKwo+ ID4+Pj4gKwlhZHY3NTExLT5yZWdtYXAgPSBkZXZtX3JlZ21hcF9pbml0X2kyYyhpMmMsICZhZHY3 NTExX3JlZ21hcF9jb25maWcpOwo+ID4+Pj4gKwlpZiAoSVNfRVJSKGFkdjc1MTEtPnJlZ21hcCkp Cj4gPj4+PiArCQlyZXR1cm4gUFRSX0VSUihhZHY3NTExLT5yZWdtYXApOwo+ID4+Pj4gKwo+ID4+ Pj4gKwlyZXQgPSByZWdtYXBfcmVhZChhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX0NISVBf UkVWSVNJT04sICZ2YWwpOwo+ID4+Pj4gKwlpZiAocmV0KQo+ID4+Pj4gKwkJcmV0dXJuIHJldDsK PiA+Pj4+ICsJZGV2X2RiZyhkZXYsICJSZXYuICVkXG4iLCB2YWwpOwo+ID4+Pj4gKwo+ID4+Pj4g KwlyZXQgPSByZWdtYXBfcmVnaXN0ZXJfcGF0Y2goYWR2NzUxMS0+cmVnbWFwLCBhZHY3NTExX2Zp eGVkX3JlZ2lzdGVycywKPiA+Pj4+ICsJCQkJICAgIEFSUkFZX1NJWkUoYWR2NzUxMV9maXhlZF9y ZWdpc3RlcnMpKTsKPiA+Pj4+ICsJaWYgKHJldCkKPiA+Pj4+ICsJCXJldHVybiByZXQ7Cj4gPj4+ PiArCj4gPj4+PiArCXJlZ21hcF93cml0ZShhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX0VE SURfSTJDX0FERFIsCj4gPj4+PiBlZGlkX2kyY19hZGRyKTsKPiA+Pj4+ICsJcmVnbWFwX3dyaXRl KGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdfUEFDS0VUX0kyQ19BRERSLAo+ID4+Pj4gKwkJ ICAgICBwYWNrZXRfaTJjX2FkZHIpOwo+ID4+Pj4gKwlyZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVn bWFwLCBBRFY3NTExX1JFR19DRUNfSTJDX0FERFIsCj4gPiAKPiA+IGNlY19pMmNfYWRkcik7Cj4g PiAKPiA+Pj4+ICsJYWR2NzUxMV9wYWNrZXRfZGlzYWJsZShhZHY3NTExLCAweGZmZmYpOwo+ID4+ Pj4gKwo+ID4+Pj4gKwlhZHY3NTExLT5pMmNfbWFpbiA9IGkyYzsKPiA+Pj4+ICsJYWR2NzUxMS0+ aTJjX2VkaWQgPSBpMmNfbmV3X2R1bW15KGkyYy0+YWRhcHRlciwgZWRpZF9pMmNfYWRkciA+PiAx KTsKPiA+Pj4+ICsJaWYgKCFhZHY3NTExLT5pMmNfZWRpZCkKPiA+Pj4+ICsJCXJldHVybiAtRU5P TUVNOwo+ID4+Pj4gKwo+ID4+Pj4gKwlpZiAoaTJjLT5pcnEpIHsKPiA+Pj4+ICsJCWluaXRfd2Fp dHF1ZXVlX2hlYWQoJmFkdjc1MTEtPndxKTsKPiA+Pj4+ICsKPiA+Pj4+ICsJCXJldCA9IGRldm1f cmVxdWVzdF90aHJlYWRlZF9pcnEoZGV2LCBpMmMtPmlycSwgTlVMTCwKPiA+Pj4+ICsJCQkJCQlh ZHY3NTExX2lycV9oYW5kbGVyLAo+ID4+Pj4gKwkJCQkJCUlSUUZfT05FU0hPVCwgZGV2X25hbWUo ZGV2KSwKPiA+Pj4+ICsJCQkJCQlhZHY3NTExKTsKPiA+Pj4+ICsJCWlmIChyZXQpCj4gPj4+PiAr CQkJZ290byBlcnJfaTJjX3VucmVnaXN0ZXJfZGV2aWNlOwo+ID4+Pj4gKwl9Cj4gPj4+PiArCj4g Pj4+PiArCS8qIENFQyBpcyB1bnVzZWQgZm9yIG5vdyAqLwo+ID4+Pj4gKwlyZWdtYXBfd3JpdGUo YWR2NzUxMS0+cmVnbWFwLCBBRFY3NTExX1JFR19DRUNfQ1RSTCwKPiA+Pj4+ICsJCSAgICAgQURW NzUxMV9DRUNfQ1RSTF9QT1dFUl9ET1dOKTsKPiA+Pj4+ICsKPiA+Pj4+ICsJYWR2NzUxMV9wb3dl cl9vZmYoYWR2NzUxMSk7Cj4gPj4+PiArCj4gPj4+PiArCWkyY19zZXRfY2xpZW50ZGF0YShpMmMs IGFkdjc1MTEpOwo+ID4+Pj4gKwo+ID4+Pj4gKyNpZmRlZiBDT05GSUdfRFJNX0kyQ19BRFY3NTEx X0FVRElPCj4gPj4+PiArCWFkdjc1MTFfYXVkaW9faW5pdCgmaTJjLT5kZXYpOwo+ID4+Pj4gKyNl bmRpZgo+ID4+PiAKPiA+Pj4gU2hvdWxkbid0IHdlIGNvbmRpdGlvbiB0aGlzIHRvIHRoZSBhdWRp byBjaGFubmVsIGJlaW5nIHNvbWVob3cgZGVzY3JpYmVkCj4gPj4+IGluIERUID8gSWYgYSBib2Fy ZCBkb2Vzbid0IHJvdXRlIGF1ZGlvIHNpZ25hbHMgdG8gdGhlIEFEVjc1MTEgYXVkaW8KPiA+Pj4g aW5wdXQsIHRoZXJlJ3Mgbm8gbmVlZCB0byByZWdpc3RlciBhbiBhdWRpbyBjb2RlYy4KPiA+PiAK PiA+PiBJIGNhbiBkbyB0aGlzIGJ1dCB0aGUgYXVkaW8gaXMgYWxyZWFkeSBjb25kaXRpb25hbGx5 IGNvbXBpbGVkIHVzaW5nCj4gPj4gbWVudWNvbmZpZy4gSXMgaXQgcmVhbGx5IG5lY2Vzc2FyeSB0 byBhZGQgdGhpcyBleHRyYSBsYXllciBvZiBjb25kaXRpb24/Cj4gPiAKPiA+IFRoZSBpZGVhIGlz IHRoYXQgZW5hYmxpbmcgc3VwcG9ydCBmb3IgQURWNzUxMSBhdWRpbyBpbiB0aGUga2VybmVsIGlz bid0Cj4gPiBjb3VwbGVkIHdpdGggd2hldGhlciB0aGUgc3lzdGVtIGluY2x1ZGVzIGF1ZGlvIHN1 cHBvcnQuIEl0IHdvdWxkIGJlCj4gPiBjb25mdXNpbmcsIGFuZCB3b3VsZCBhbHNvIHdhc3RlIHJl c291cmNlcywgdG8gY3JlYXRlIGEgTGludXggc291bmQgZGV2aWNlCj4gPiB3aGVuIG5vIHNvdW5k IGNoYW5uZWwgaXMgcm91dGVkIG9uIHRoZSBib2FyZC4KPiAKPiBPaywgd2lsbCBkbyB0aGF0IGlu IG5leHQgdmVyc2lvbi4gQW5vdGhlciBxdWVzdGlvbjogSSBhbSBmYWNpbmcgYSBwcm9ibGVtCj4g d2hlbiBjb21waWxpbmcgQUxTQSBhcyBhIG1vZHVsZSwgYXMgdGhlIEFEVjc1MTEgYXVkaW8gaXMg bm90IGVtYmVkZGVkIGludG8KPiBBTFNBIHRoZSBjb21waWxhdGlvbiBmYWlscyB3aXRoIHVuZGVm aW5lZCByZWZlcmVuY2VzIHRvIEFMU0EgZnVuY3Rpb25zLiBUaGUKPiBzb2x1dGlvbiB0aGF0IEkg YW0gcGxhbm5pbmcgdG8gdXNlIGlzIHRvIGFkZCBhIGRlZmF1bHQgdmFsdWUgdG8gdGhlIEFEVjc1 MTEKPiBrY29uZmlnIGVudHJ5IHNvIHRoYXQgdGhlIGRyaXZlciBpcyBjb21waWxlZCBhcyBtb2R1 bGUgd2hlbiBBTFNBIGlzIGEKPiBtb2R1bGUgYW5kIGFzIGVtYmVkZGVkIGlmIEFMU0EgaXMgZW1i ZWRkZWQuIElzIHRoaXMgb2theSBvciBpcyB0aGVyZQo+IGFub3RoZXIgc29sdXRpb24gd2l0aG91 dCBtb3ZpbmcgdGhlIEFEVjc1MTEgYXVkaW8gdG8gdGhlIEFMU0EgZGlyZWN0b3J5PwoKWW91IGNh biB3cml0ZSB0aGUgS2NvbmZpZyBkZXBlbmRlbmN5IGFzCgpkZXBlbmRzIG9uIERSTV9JMkNfQURW NzUxMQpkZXBlbmRzIG9uIFNORF9TT0M9eSB8fCAoU05EX1NPQyAmJiBEUk1fSTJDX0FEVjc1MTE9 bSkKCj4gPj4+PiArCj4gPj4+PiArCWFkdjc1MTFfc2V0X2xpbmtfY29uZmlnKGFkdjc1MTEsICZs aW5rX2NvbmZpZyk7Cj4gPj4+PiArCj4gPj4+PiArCS8qIEVuYWJsZSBIRE1JIG1vZGUgKi8KPiA+ Pj4+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdfSERD UF9IRE1JX0NGRywKPiA+Pj4+ICsJCQlBRFY3NTExX0hETUlfQ0ZHX01PREVfTUFTSywKPiA+Pj4+ ICsJCQlBRFY3NTExX0hETUlfQ0ZHX01PREVfSERNSSk7Cj4gPj4+PiArCj4gPj4+PiArCXJldHVy biAwOwo+ID4+Pj4gKwo+ID4+Pj4gK2Vycl9pMmNfdW5yZWdpc3Rlcl9kZXZpY2U6Cj4gPj4+PiAr CWkyY191bnJlZ2lzdGVyX2RldmljZShhZHY3NTExLT5pMmNfZWRpZCk7Cj4gPj4+PiArCj4gPj4+ PiArCXJldHVybiByZXQ7Cj4gPj4+PiArfQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 05 Apr 2016 19:03:55 +0300 Subject: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support In-Reply-To: <57039AE6.7050601@synopsys.com> References: <2037371.nWufVmEmFd@avalon> <57039AE6.7050601@synopsys.com> List-ID: Message-ID: <4962391.ZSHHxaj8ik@avalon> To: linux-snps-arc@lists.infradead.org Hi Jose, On Tuesday 05 Apr 2016 12:00:54 Jose Abreu wrote: > On 04-04-2016 22:41, Laurent Pinchart wrote: > > On Monday 04 Apr 2016 10:05:39 Jose Abreu wrote: > >> On 01-04-2016 18:10, Laurent Pinchart wrote: > >>> On Monday 28 Mar 2016 15:36:09 Jose Abreu wrote: > >>>> This patch adds audio support for the ADV7511 HDMI transmitter > >>>> using ALSA SoC. > >>>> > >>>> The code was ported from Analog Devices linux tree from > >>>> commit 1770c4a1e32b ("Merge remote-tracking branch > >>>> > >>>> 'xilinx/master' into xcomm_zynq"), which is available at: > >>>> - https://github.com/analogdevicesinc/linux/ > >>>> > >>>> The main core file was renamed from adv7511.c to adv7511_core.c > >>>> so that audio and video compile into a single adv7511.ko module > >>>> and to keep up with Analog Devices kernel tree. > >>>> > >>>> The audio can be disabled using menu-config so it is possible > >>>> to use only video mode. > >>>> > >>>> The HDMI mode is automatically started at boot and the audio > >>>> (when enabled) registers as a codec into ALSA. > >>>> > >>>> SPDIF DAI format was also added to ASoC as it is required > >>>> by adv7511 audio. > >>>> > >>>> Signed-off-by: Jose Abreu > >>>> --- > >>>> > >>>> No changes v1 -> v2. > >>>> > >>>> drivers/gpu/drm/i2c/Kconfig | 11 + > >>>> drivers/gpu/drm/i2c/Makefile | 2 + > >>>> drivers/gpu/drm/i2c/adv7511.c | 1024 > >>>> ---------------------------- > >>>> drivers/gpu/drm/i2c/adv7511.h | 41 ++ > >>>> drivers/gpu/drm/i2c/adv7511_audio.c | 310 +++++++++++ > >>>> drivers/gpu/drm/i2c/adv7511_core.c | 1005 > >>>> ++++++++++++++++++++++++++++ > >>> > >>> Please use git-format-patch -M to detect renames if you send a new > >>> version > >>> of this series, it will help with review. > >> > >> Ok, will do that in next version. > >> > >>>> include/sound/soc-dai.h | 1 + > >>>> 7 files changed, 1370 insertions(+), 1024 deletions(-) > >>>> delete mode 100644 drivers/gpu/drm/i2c/adv7511.c > >>>> create mode 100644 drivers/gpu/drm/i2c/adv7511_audio.c > >>>> create mode 100644 drivers/gpu/drm/i2c/adv7511_core.c > >>> > >>> [snip] > >>> > >>>> diff --git a/drivers/gpu/drm/i2c/adv7511_core.c > >>>> b/drivers/gpu/drm/i2c/adv7511_core.c new file mode 100644 > >>>> index 0000000..d54256a > >>>> --- /dev/null > >>>> +++ b/drivers/gpu/drm/i2c/adv7511_core.c > >>> > >>> [snip] > >>> > >>>> +static int adv7511_probe(struct i2c_client *i2c, const struct > >>>> i2c_device_id *id) +{ > >>>> + struct adv7511_link_config link_config; > >>>> + struct adv7511 *adv7511; > >>>> + struct device *dev = &i2c->dev; > >>>> + unsigned int val; > >>>> + int ret; > >>>> + > >>>> + if (!dev->of_node) > >>>> + return -EINVAL; > >>>> + > >>>> + adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL); > >>>> + if (!adv7511) > >>>> + return -ENOMEM; > >>>> + > >>>> + adv7511->powered = false; > >>>> + adv7511->status = connector_status_disconnected; > >>>> + > >>>> + ret = adv7511_parse_dt(dev->of_node, &link_config); > >>>> + if (ret) > >>>> + return ret; > >>>> + > >>>> + /* > >>>> + * The power down GPIO is optional. If present, toggle it from active > >>>> to > >>>> + * inactive to wake up the encoder. > >>>> + */ > >>>> + adv7511->gpio_pd = devm_gpiod_get_optional(dev, "pd", > > > > GPIOD_OUT_HIGH); > > > >>>> + if (IS_ERR(adv7511->gpio_pd)) > >>>> + return PTR_ERR(adv7511->gpio_pd); > >>>> + > >>>> + if (adv7511->gpio_pd) { > >>>> + mdelay(5); > >>>> + gpiod_set_value_cansleep(adv7511->gpio_pd, 0); > >>>> + } > >>>> + > >>>> + adv7511->regmap = devm_regmap_init_i2c(i2c, &adv7511_regmap_config); > >>>> + if (IS_ERR(adv7511->regmap)) > >>>> + return PTR_ERR(adv7511->regmap); > >>>> + > >>>> + ret = regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val); > >>>> + if (ret) > >>>> + return ret; > >>>> + dev_dbg(dev, "Rev. %d\n", val); > >>>> + > >>>> + ret = regmap_register_patch(adv7511->regmap, adv7511_fixed_registers, > >>>> + ARRAY_SIZE(adv7511_fixed_registers)); > >>>> + if (ret) > >>>> + return ret; > >>>> + > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, > >>>> edid_i2c_addr); > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR, > >>>> + packet_i2c_addr); > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, > > > > cec_i2c_addr); > > > >>>> + adv7511_packet_disable(adv7511, 0xffff); > >>>> + > >>>> + adv7511->i2c_main = i2c; > >>>> + adv7511->i2c_edid = i2c_new_dummy(i2c->adapter, edid_i2c_addr >> 1); > >>>> + if (!adv7511->i2c_edid) > >>>> + return -ENOMEM; > >>>> + > >>>> + if (i2c->irq) { > >>>> + init_waitqueue_head(&adv7511->wq); > >>>> + > >>>> + ret = devm_request_threaded_irq(dev, i2c->irq, NULL, > >>>> + adv7511_irq_handler, > >>>> + IRQF_ONESHOT, dev_name(dev), > >>>> + adv7511); > >>>> + if (ret) > >>>> + goto err_i2c_unregister_device; > >>>> + } > >>>> + > >>>> + /* CEC is unused for now */ > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL, > >>>> + ADV7511_CEC_CTRL_POWER_DOWN); > >>>> + > >>>> + adv7511_power_off(adv7511); > >>>> + > >>>> + i2c_set_clientdata(i2c, adv7511); > >>>> + > >>>> +#ifdef CONFIG_DRM_I2C_ADV7511_AUDIO > >>>> + adv7511_audio_init(&i2c->dev); > >>>> +#endif > >>> > >>> Shouldn't we condition this to the audio channel being somehow described > >>> in DT ? If a board doesn't route audio signals to the ADV7511 audio > >>> input, there's no need to register an audio codec. > >> > >> I can do this but the audio is already conditionally compiled using > >> menuconfig. Is it really necessary to add this extra layer of condition? > > > > The idea is that enabling support for ADV7511 audio in the kernel isn't > > coupled with whether the system includes audio support. It would be > > confusing, and would also waste resources, to create a Linux sound device > > when no sound channel is routed on the board. > > Ok, will do that in next version. Another question: I am facing a problem > when compiling ALSA as a module, as the ADV7511 audio is not embedded into > ALSA the compilation fails with undefined references to ALSA functions. The > solution that I am planning to use is to add a default value to the ADV7511 > kconfig entry so that the driver is compiled as module when ALSA is a > module and as embedded if ALSA is embedded. Is this okay or is there > another solution without moving the ADV7511 audio to the ALSA directory? You can write the Kconfig dependency as depends on DRM_I2C_ADV7511 depends on SND_SOC=y || (SND_SOC && DRM_I2C_ADV7511=m) > >>>> + > >>>> + adv7511_set_link_config(adv7511, &link_config); > >>>> + > >>>> + /* Enable HDMI mode */ > >>>> + regmap_update_bits(adv7511->regmap, ADV7511_REG_HDCP_HDMI_CFG, > >>>> + ADV7511_HDMI_CFG_MODE_MASK, > >>>> + ADV7511_HDMI_CFG_MODE_HDMI); > >>>> + > >>>> + return 0; > >>>> + > >>>> +err_i2c_unregister_device: > >>>> + i2c_unregister_device(adv7511->i2c_edid); > >>>> + > >>>> + return ret; > >>>> +} -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584AbcDEQD7 (ORCPT ); Tue, 5 Apr 2016 12:03:59 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:49154 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbcDEQD5 (ORCPT ); Tue, 5 Apr 2016 12:03:57 -0400 From: Laurent Pinchart To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, tixy@linaro.org, mark.rutland@arm.com, broonie@kernel.org, Alexey.Brodkin@synopsys.com, lgirdwood@gmail.com, yitian.bu@tangramtek.com, wsa+renesas@sang-engineering.com, laurent.pinchart+renesas@ideasonboard.com, nariman@opensource.wolfsonmicro.com, Maruthi.Bayyavarapu@amd.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Vineet.Gupta1@synopsys.com, buyitian@gmail.com, perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org, galak@codeaurora.org, alexander.deucher@amd.com, CARLOS.PALMINHA@synopsys.com Subject: Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Date: Tue, 05 Apr 2016 19:03:55 +0300 Message-ID: <4962391.ZSHHxaj8ik@avalon> User-Agent: KMail/4.14.10 (Linux/4.1.15-gentoo-r1; KDE/4.14.16; x86_64; ; ) In-Reply-To: <57039AE6.7050601@synopsys.com> References: <2037371.nWufVmEmFd@avalon> <57039AE6.7050601@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jose, On Tuesday 05 Apr 2016 12:00:54 Jose Abreu wrote: > On 04-04-2016 22:41, Laurent Pinchart wrote: > > On Monday 04 Apr 2016 10:05:39 Jose Abreu wrote: > >> On 01-04-2016 18:10, Laurent Pinchart wrote: > >>> On Monday 28 Mar 2016 15:36:09 Jose Abreu wrote: > >>>> This patch adds audio support for the ADV7511 HDMI transmitter > >>>> using ALSA SoC. > >>>> > >>>> The code was ported from Analog Devices linux tree from > >>>> commit 1770c4a1e32b ("Merge remote-tracking branch > >>>> > >>>> 'xilinx/master' into xcomm_zynq"), which is available at: > >>>> - https://github.com/analogdevicesinc/linux/ > >>>> > >>>> The main core file was renamed from adv7511.c to adv7511_core.c > >>>> so that audio and video compile into a single adv7511.ko module > >>>> and to keep up with Analog Devices kernel tree. > >>>> > >>>> The audio can be disabled using menu-config so it is possible > >>>> to use only video mode. > >>>> > >>>> The HDMI mode is automatically started at boot and the audio > >>>> (when enabled) registers as a codec into ALSA. > >>>> > >>>> SPDIF DAI format was also added to ASoC as it is required > >>>> by adv7511 audio. > >>>> > >>>> Signed-off-by: Jose Abreu > >>>> --- > >>>> > >>>> No changes v1 -> v2. > >>>> > >>>> drivers/gpu/drm/i2c/Kconfig | 11 + > >>>> drivers/gpu/drm/i2c/Makefile | 2 + > >>>> drivers/gpu/drm/i2c/adv7511.c | 1024 > >>>> ---------------------------- > >>>> drivers/gpu/drm/i2c/adv7511.h | 41 ++ > >>>> drivers/gpu/drm/i2c/adv7511_audio.c | 310 +++++++++++ > >>>> drivers/gpu/drm/i2c/adv7511_core.c | 1005 > >>>> ++++++++++++++++++++++++++++ > >>> > >>> Please use git-format-patch -M to detect renames if you send a new > >>> version > >>> of this series, it will help with review. > >> > >> Ok, will do that in next version. > >> > >>>> include/sound/soc-dai.h | 1 + > >>>> 7 files changed, 1370 insertions(+), 1024 deletions(-) > >>>> delete mode 100644 drivers/gpu/drm/i2c/adv7511.c > >>>> create mode 100644 drivers/gpu/drm/i2c/adv7511_audio.c > >>>> create mode 100644 drivers/gpu/drm/i2c/adv7511_core.c > >>> > >>> [snip] > >>> > >>>> diff --git a/drivers/gpu/drm/i2c/adv7511_core.c > >>>> b/drivers/gpu/drm/i2c/adv7511_core.c new file mode 100644 > >>>> index 0000000..d54256a > >>>> --- /dev/null > >>>> +++ b/drivers/gpu/drm/i2c/adv7511_core.c > >>> > >>> [snip] > >>> > >>>> +static int adv7511_probe(struct i2c_client *i2c, const struct > >>>> i2c_device_id *id) +{ > >>>> + struct adv7511_link_config link_config; > >>>> + struct adv7511 *adv7511; > >>>> + struct device *dev = &i2c->dev; > >>>> + unsigned int val; > >>>> + int ret; > >>>> + > >>>> + if (!dev->of_node) > >>>> + return -EINVAL; > >>>> + > >>>> + adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL); > >>>> + if (!adv7511) > >>>> + return -ENOMEM; > >>>> + > >>>> + adv7511->powered = false; > >>>> + adv7511->status = connector_status_disconnected; > >>>> + > >>>> + ret = adv7511_parse_dt(dev->of_node, &link_config); > >>>> + if (ret) > >>>> + return ret; > >>>> + > >>>> + /* > >>>> + * The power down GPIO is optional. If present, toggle it from active > >>>> to > >>>> + * inactive to wake up the encoder. > >>>> + */ > >>>> + adv7511->gpio_pd = devm_gpiod_get_optional(dev, "pd", > > > > GPIOD_OUT_HIGH); > > > >>>> + if (IS_ERR(adv7511->gpio_pd)) > >>>> + return PTR_ERR(adv7511->gpio_pd); > >>>> + > >>>> + if (adv7511->gpio_pd) { > >>>> + mdelay(5); > >>>> + gpiod_set_value_cansleep(adv7511->gpio_pd, 0); > >>>> + } > >>>> + > >>>> + adv7511->regmap = devm_regmap_init_i2c(i2c, &adv7511_regmap_config); > >>>> + if (IS_ERR(adv7511->regmap)) > >>>> + return PTR_ERR(adv7511->regmap); > >>>> + > >>>> + ret = regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val); > >>>> + if (ret) > >>>> + return ret; > >>>> + dev_dbg(dev, "Rev. %d\n", val); > >>>> + > >>>> + ret = regmap_register_patch(adv7511->regmap, adv7511_fixed_registers, > >>>> + ARRAY_SIZE(adv7511_fixed_registers)); > >>>> + if (ret) > >>>> + return ret; > >>>> + > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, > >>>> edid_i2c_addr); > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR, > >>>> + packet_i2c_addr); > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, > > > > cec_i2c_addr); > > > >>>> + adv7511_packet_disable(adv7511, 0xffff); > >>>> + > >>>> + adv7511->i2c_main = i2c; > >>>> + adv7511->i2c_edid = i2c_new_dummy(i2c->adapter, edid_i2c_addr >> 1); > >>>> + if (!adv7511->i2c_edid) > >>>> + return -ENOMEM; > >>>> + > >>>> + if (i2c->irq) { > >>>> + init_waitqueue_head(&adv7511->wq); > >>>> + > >>>> + ret = devm_request_threaded_irq(dev, i2c->irq, NULL, > >>>> + adv7511_irq_handler, > >>>> + IRQF_ONESHOT, dev_name(dev), > >>>> + adv7511); > >>>> + if (ret) > >>>> + goto err_i2c_unregister_device; > >>>> + } > >>>> + > >>>> + /* CEC is unused for now */ > >>>> + regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL, > >>>> + ADV7511_CEC_CTRL_POWER_DOWN); > >>>> + > >>>> + adv7511_power_off(adv7511); > >>>> + > >>>> + i2c_set_clientdata(i2c, adv7511); > >>>> + > >>>> +#ifdef CONFIG_DRM_I2C_ADV7511_AUDIO > >>>> + adv7511_audio_init(&i2c->dev); > >>>> +#endif > >>> > >>> Shouldn't we condition this to the audio channel being somehow described > >>> in DT ? If a board doesn't route audio signals to the ADV7511 audio > >>> input, there's no need to register an audio codec. > >> > >> I can do this but the audio is already conditionally compiled using > >> menuconfig. Is it really necessary to add this extra layer of condition? > > > > The idea is that enabling support for ADV7511 audio in the kernel isn't > > coupled with whether the system includes audio support. It would be > > confusing, and would also waste resources, to create a Linux sound device > > when no sound channel is routed on the board. > > Ok, will do that in next version. Another question: I am facing a problem > when compiling ALSA as a module, as the ADV7511 audio is not embedded into > ALSA the compilation fails with undefined references to ALSA functions. The > solution that I am planning to use is to add a default value to the ADV7511 > kconfig entry so that the driver is compiled as module when ALSA is a > module and as embedded if ALSA is embedded. Is this okay or is there > another solution without moving the ADV7511 audio to the ALSA directory? You can write the Kconfig dependency as depends on DRM_I2C_ADV7511 depends on SND_SOC=y || (SND_SOC && DRM_I2C_ADV7511=m) > >>>> + > >>>> + adv7511_set_link_config(adv7511, &link_config); > >>>> + > >>>> + /* Enable HDMI mode */ > >>>> + regmap_update_bits(adv7511->regmap, ADV7511_REG_HDCP_HDMI_CFG, > >>>> + ADV7511_HDMI_CFG_MODE_MASK, > >>>> + ADV7511_HDMI_CFG_MODE_HDMI); > >>>> + > >>>> + return 0; > >>>> + > >>>> +err_i2c_unregister_device: > >>>> + i2c_unregister_device(adv7511->i2c_edid); > >>>> + > >>>> + return ret; > >>>> +} -- Regards, Laurent Pinchart