From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "\"Cheng Renquan (程任全)\"" <crquan@gmail.com>
Cc: Alasdair G Kergon <agk@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Jonathan Brassow <jbrassow@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Milan Broz <mbroz@redhat.com>, Andi Kleen <ak@suse.de>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
Takahiro Yasui <tyasui@redhat.com>
Subject: Re: [git pull] device-mapper patches for 2.6.29
Date: Tue, 06 Jan 2009 12:59:40 +0100 [thread overview]
Message-ID: <496347AC.5000203@s5r6.in-berlin.de> (raw)
In-Reply-To: <91b13c310901051932p1343f9eei1db5534e6e10d238@mail.gmail.com>
Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@redhat.com> wrote:
>> On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
>>> So now maybe we can add a null macro to module_refcount if
>>> CONFIG_MODULE_UNLOAD undefined?
>>
>> Do we even need the test at all?
>
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?
The fact that module_refcount may be undefined is an indicator that this
is not an API for general use.
Why are you wanting to peek into the reference count of a module?
Shouldn't you have everything covered by properly recounting all your
data objects? (Preferably via the kref API.)
--
Stefan Richter
-=====-==--= ---= --==-
http://arcgraph.de/sr/
prev parent reply other threads:[~2009-01-06 11:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 12:51 [git pull] device-mapper patches for 2.6.28 Alasdair G Kergon
2008-10-10 12:51 ` Alasdair G Kergon
2009-01-05 19:18 ` [git pull] device-mapper patches for 2.6.29 Alasdair G Kergon
2009-01-05 19:18 ` Alasdair G Kergon
2009-01-06 2:51 ` Linus Torvalds
2009-01-06 2:51 ` Linus Torvalds
2009-01-06 3:04 ` Stephen Rothwell
2009-01-06 3:04 ` Stephen Rothwell
2009-01-06 3:14 ` Alasdair G Kergon
2009-01-06 3:14 ` [dm-devel] " Alasdair G Kergon
2009-01-06 3:15 ` Cheng Renquan (程任全)
2009-01-06 3:15 ` Cheng Renquan (程任全)
2009-01-06 3:21 ` Alasdair G Kergon
2009-01-06 3:21 ` Alasdair G Kergon
2009-01-06 3:32 ` Cheng Renquan (程任全)
2009-01-06 3:32 ` Cheng Renquan (程任全)
2009-01-06 3:48 ` Alasdair G Kergon
2009-01-06 3:48 ` [dm-devel] " Alasdair G Kergon
2009-01-06 11:59 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496347AC.5000203@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=agk@redhat.com \
--cc=ak@suse.de \
--cc=crquan@gmail.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jbrassow@redhat.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tyasui@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.