From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Calculate mirror log size instead of hardcoding 1 extent size.
Date: Tue, 06 Jan 2009 18:21:17 +0100 [thread overview]
Message-ID: <4963930D.5030404@redhat.com> (raw)
In-Reply-To: <4952F985.5010307@ce.jp.nec.com>
Jun'ichi Nomura wrote:
> Milan Broz wrote:
>> + if (!(r = _for_each_pv(cmd, seg->log_lv, 0, seg->log_lv->le_count?:1,
>
> "seg->log_lv->le_count?:1" could be just "seg->log_lv->le_count",
> to avoid possible future confusion.
> (I.e. there is no explanation why we pass 1 when le_count is 0.)
> And if the seg->log_lv is empty, _for_each_pv() will just fail anyway
> by not finding a matching segment, regardless of len = 0 or 1.
> If it is possible to pass an empty seg->log_lv here in future,
> le_count check should be done in the above "if", I think.
Yes, thanks, I'll fix the commit.
Milan
prev parent reply other threads:[~2009-01-06 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 11:18 [PATCH] Calculate mirror log size instead of hardcoding 1 extent size Milan Broz
2008-12-19 14:44 ` Alasdair G Kergon
2008-12-25 3:09 ` Jun'ichi Nomura
2009-01-06 17:21 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4963930D.5030404@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.