Re: [PATCH] Corrections to affs and sfs

[Krzysztof Smiechowicz <deadwood@wp.pl>]

Robert Millan pisze:

>> Index: fs/sfs.c
>> ===================================================================
>> --- fs/sfs.c	(revision 1919)
>> +++ fs/sfs.c	(working copy)
>> @@ -172,7 +172,8 @@
>>  	  return grub_errno;
>>  	}
>>  
>> -      for (i = 0; i < grub_be_to_cpu16 (tree->nodes); i++)
>> +      grub_uint16_t nodescount = grub_be_to_cpu16(tree->nodes);
>> +      for (i = nodescount - 1; i >= 0; i--)
> 
> nodescount is only used once; why adding a variable?
> 
>>  	  /* Follow the tree down to the leaf level.  */
>> -	  if ((grub_be_to_cpu32 (EXTNODE(tree, i)->key) >= block)
>> +	  if ((grub_be_to_cpu32 (EXTNODE(tree, i)->key) <= block)
>>  	      && !tree->leaf)
>>  	    {
>> -	      next = grub_be_to_cpu32 (EXTNODE (tree, i - 1)->data);
>> -	      break;
>> -	    }
>> -
>> -	  /* In case the last node is reached just use that one, it is
>> -	     the right match.  */
>> -	  if (i + 1 == grub_be_to_cpu16 (tree->nodes) && !tree->leaf)
>> -	    {
>>  	      next = grub_be_to_cpu32 (EXTNODE (tree, i)->data);
>>  	      break;
>>  	    }
> 
> I'm not familiar with our SFS code.  Marco, if you have a minute could you
> review this part?
> 

Hello,

Any news about applying this patch? :)

Best regards,
Krzysztof
AROS Development Team