All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jack Steiner <steiner@sgi.com>, Cliff Wickman <cpw@sgi.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Jes Sorensen <jes@sgi.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/11] x86: cpumask: some more cpumask cleanups - flush_tlb_*
Date: Tue, 06 Jan 2009 18:50:26 -0800	[thread overview]
Message-ID: <49641872.3000404@sgi.com> (raw)
In-Reply-To: <200901071242.42573.rusty@rustcorp.com.au>

Rusty Russell wrote:
> On Tuesday 06 January 2009 14:19:35 Mike Travis wrote:
>> Ingo Molnar wrote:
>>> Quite good! Can we fix those TLB flush cpumask uses too?
>> Here is one proposal.
> 
> Here's what I had.  It's untested though...
> 
> x86: change flush_tlb_others to take a const struct cpumask *. FIXME: REVIEW
> 
> This is made a little more tricky by uv_flush_tlb_others which
> actually alters its argument, for an IPI to be sent to the remaining
> cpus in the mask.
> 
> I solve this by allocating a cpumask_var_t for this case and falling back
> to IPI should this fail.

I thought about this but I wondered if we wanted to add the overhead of a kmalloc
call for every tlb flush?  For a UV system, simultaneous flushes will be quite common,
so introducing two kmalloc's in the path could really hamper performance.

Thanks,
Mike

      reply	other threads:[~2009-01-07  2:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-04 13:17 [PATCH 00/11] x86: cpumask: some more cpumask cleanups Mike Travis
2009-01-04 13:18 ` [PATCH 01/11] [PATCH] ia64: cpumask fix for is_affinity_mask_valid() Mike Travis
2009-01-04 13:18 ` [PATCH 02/11] cpumask: update local_cpus_show to use new cpumask API Mike Travis
2009-01-04 13:18 ` [PATCH 03/11] cpumask: update pci_bus_show_cpuaffinity " Mike Travis
2009-01-05 19:27   ` Jesse Barnes
2009-01-05 19:31     ` Mike Travis
2009-01-05 19:59       ` Jesse Barnes
2009-01-07 15:19         ` Ingo Molnar
2009-01-07 16:59           ` Jesse Barnes
2009-01-05 19:44     ` Linus Torvalds
2009-01-05 19:49       ` Jesse Barnes
2009-01-04 13:18 ` [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot code Mike Travis
2009-01-04 13:18 ` [PATCH 05/11] x86: clean up speedstep-centrino and reduce cpumask_t usage From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2009-01-04 13:18 ` [PATCH 06/11] cpumask: Replace CPUMASK_ALLOC etc with cpumask_var_t. " Mike Travis
2009-01-04 13:18 ` [PATCH 07/11] cpumask: convert struct cpufreq_policy to " Mike Travis
2009-01-04 13:18 ` [PATCH 08/11] cpumask: use work_on_cpu in acpi/cstate.c Mike Travis
2009-01-04 13:18 ` [PATCH 09/11] cpumask: use cpumask_var_t in acpi-cpufreq.c Mike Travis
2009-01-04 13:18 ` [PATCH 10/11] cpumask: use work_on_cpu in acpi-cpufreq.c for drv_read and drv_write Mike Travis
2009-01-04 13:18 ` [PATCH 11/11] cpumask: use work_on_cpu in acpi-cpufreq.c for read_measured_perf_ctrs Mike Travis
2009-01-04 14:44 ` [PATCH 00/11] x86: cpumask: some more cpumask cleanups Ingo Molnar
2009-01-05 18:28   ` Mike Travis
2009-01-06  3:49   ` [PATCH 00/11] x86: cpumask: some more cpumask cleanups - flush_tlb_* Mike Travis
2009-01-07  2:12     ` Rusty Russell
2009-01-07  2:50       ` Mike Travis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49641872.3000404@sgi.com \
    --to=travis@sgi.com \
    --cc=cl@linux-foundation.org \
    --cc=cpw@sgi.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rusty@rustcorp.com.au \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.