From: Tony Battersby <tonyb@cybernetics.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu
Subject: Re: [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5)
Date: Wed, 07 Jan 2009 09:52:31 -0500 [thread overview]
Message-ID: <4964C1AF.3020103@cybernetics.com> (raw)
In-Reply-To: <49648AA3.5070401@nokia.com>
Aaro Koskinen wrote:
> Hello,
>
> ext Tony Battersby wrote:
>
>> From the description of this patch, I assume that it is a cleanup
>> instead of a fix for an actual problem. Correspondingly, I don't have a
>> specific testcase that is improved by this patch. I also have not
>> analyzed the source to see what the patch is trying to do. However, the
>> current form of the patch passes testing as described above.
>>
>
> You can try to do the following test with and without the patch:
>
> echo "scsi remove-single-device some_valid_address_with_a_target >
> /proc/scsi/scsi"
>
> Then do e.g. "resetdev" or "cleardev" to that target through the drivers
> /proc interface.
>
> A.
>
>
OK, I just tested that and verified that your patch fixes it. Thanks!
Tony
next prev parent reply other threads:[~2009-01-07 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 20:27 [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5) Tony Battersby
2008-12-29 20:55 ` Tony Battersby
2008-12-30 10:10 ` Aaro Koskinen
2008-12-30 19:16 ` James Bottomley
2009-01-06 16:26 ` Tony Battersby
2009-01-07 10:57 ` Aaro Koskinen
2009-01-07 14:52 ` Tony Battersby [this message]
2009-01-06 20:00 ` [PATCH] sym53c8xx_2: Keep transfer negotiations valid (2.6.27.5) Tony Battersby
2009-01-07 13:19 ` Aaro Koskinen
2009-01-15 15:13 ` Aaro Koskinen
2009-01-16 14:28 ` Tony Battersby
2009-01-21 18:27 ` Tony Battersby
2009-01-06 22:00 ` [PATCH] sym53c8xx_2: lun to_clear flag not re-initialized (2.6.27.5) Tony Battersby
-- strict thread matches above, loose matches on Subject: below --
2008-12-29 20:20 [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5) Tony Battersby
2008-11-19 14:58 Koskinen Aaro (NSN - FI/Helsinki)
2008-12-15 16:56 ` Mike Christie
2008-12-15 17:13 ` James Bottomley
2008-12-16 17:14 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4964C1AF.3020103@cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.