Re: [Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour

[Alexander Graf <agraf@suse.de>]

Ian Jackson wrote:
> Stefano Stabellini writes ("[Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour"):
>   
>> the usb-hid spec states that the SET_IDLE request has a 16bit value,
>> where the upper byte specifies the idle rate (currently unimplemented,
>> we handle only the 0 case, meaning infinite duration) and the lower
>> byte specifies the report id (0 means all reports).
>> In our code we do idle = value, while it should be idle = "upper byte",
>> especially if the guest issues a GET_IDLE, we should return only the
>> idle rate while we are returning only the report id.
>> In practice it doesn't make much difference because I have only seen
>> SET_VALUE with both bytes set to 0 so far, but still it is wrong.
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>     
>
> Stefano's patch looks good to me.
>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   

Shouldn't that be Ian rather than Stefano? :-)

Alex