From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKbeM-00014C-AV
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:52:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKbeL-00013o-Q3
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:52:58 -0500
Received: from [199.232.76.173] (port=60599 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKbeL-00013k-IA
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:52:57 -0500
Received: from qw-out-1920.google.com ([74.125.92.150]:21120)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LKbeL-0007PB-7U
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:52:57 -0500
Received: by qw-out-1920.google.com with SMTP id 5so3856946qwc.4
	for <qemu-devel@nongnu.org>; Wed, 07 Jan 2009 08:52:56 -0800 (PST)
Message-ID: <4964DDE1.6040809@codemonkey.ws>
Date: Wed, 07 Jan 2009 10:52:49 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/5] Redirect slirp traffic to/from qemu
	character device.
References: <20090105151459.3819.79836.stgit@dhcp-1-237.tlv.redhat.com>
	<20090105151504.3819.46080.stgit@dhcp-1-237.tlv.redhat.com>
In-Reply-To: <20090105151504.3819.46080.stgit@dhcp-1-237.tlv.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  slirp/libslirp.h |    5 ++-
>  slirp/main.h     |    1 +
>  slirp/misc.c     |    2 +
>  slirp/sbuf.c     |    2 +
>  slirp/slirp.c    |   62 +++++++++++++++++++++++++++++++++-
>  slirp/socket.c   |   99 +++++++++++++++++++++++++++++++++++++++++++-----------
>  slirp/socket.h   |    2 +
>  slirp/tcp_subr.c |    5 +++
>  8 files changed, 154 insertions(+), 24 deletions(-)
>
>   

This patch breaks the Windows build.

In file included from /home/anthony/svn/qemu/slirp/slirp.h:215,
                 from /home/anthony/svn/qemu/slirp/slirp.c:24:
/home/anthony/svn/qemu/slirp/socket.h:90: warning: 'struct iovec' 
declared inside parameter list
/home/anthony/svn/qemu/slirp/socket.h:90: warning: its scope is only 
this definition or declaration, which is probably not what you want
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_select_poll':
/home/anthony/svn/qemu/slirp/slirp.c:458: warning: passing argument 2 of 
'send' from incompatible pointer type
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_send':
/home/anthony/svn/qemu/slirp/slirp.c:749: warning: implicit declaration 
of function 'qemu_chr_write'
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_socket_can_recv':
/home/anthony/svn/qemu/slirp/slirp.c:774: error: array type has 
incomplete element type
/home/anthony/svn/qemu/slirp/slirp.c:774: warning: unused variable 'iov'
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_socket_recv':
/home/anthony/svn/qemu/slirp/slirp.c:800: warning: pointer targets in 
passing argument 2 of 'soreadbuf' differ in signedness


You probably need to add an #include to get our version of struct iovec 
for Windows.

Regards,

Anthony Liguori