From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79DDC4167B for ; Fri, 2 Dec 2022 10:05:00 +0000 (UTC) Subject: Re: ['meta-python][PATCH V2' 2/2] python3-uefi-firmware: add recipe for version 1.9 To: openembedded-devel@lists.openembedded.org From: "tomzy" X-Originating-Location: Warsaw, Mazovia, PL (84.10.27.202) X-Originating-Platform: Linux Firefox 107 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 02 Dec 2022 02:04:54 -0800 References: In-Reply-To: Message-ID: <4965.1669975494771605239@lists.openembedded.org> Content-Type: multipart/alternative; boundary="CyIUnnh5rRWGyffmZaFc" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 02 Dec 2022 10:05:00 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/99913 --CyIUnnh5rRWGyffmZaFc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Dec 2, 2022 at 10:56 AM, Michael Opdenacker wrote: >=20 > Hi Tomasz Hi >=20 > Thanks for the patches! >=20 > On 12/1/22 09:24, tomzy wrote: >=20 >> Install uefi-firmware-parser tool >>=20 >> The UEFI firmware parseer is a simple module and set of scripts for >> parsing, extracting, and recreating UEFI firmware volumes. >>=20 >> Signed-off-by: Tomasz =C5=BByjewski >> --- >> .../python/python3-uefi-firmware_1.9.bb | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 >> meta-python/recipes-devtools/python/python3-uefi-firmware_1.9.bb >=20 > However, if I apply your patch through "git am", the author of the > commit will be: > tomzy > instead of > Tomasz =C5=BByjewski >=20 > Because of this issue, the maintainer has to manually fix this field > when accepting your patch. Worse, if he doesn't catch this, that's > harder to fix afterwards. I was not aware of this issue. I must have missed it in guidelines. Sorry f= or that! >=20 >=20 > You should be able to fix this by running: > git config --global sendemail.from "tomasz.zyjewski@3mdeb.com" >=20 > This should add a "From" field to the sent patch which "git am" should > be able to match with your name. > See > https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#S= ending_using_git-send-email >=20 >=20 > Could you try to send an update (don't hesitate to send a private one to > me first)? Thank you, I will try that. Should I use `michael.opdenacker@bootlin.com` ? >=20 >=20 > Thanks in advance > Michael. >=20 > -- > Michael Opdenacker, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --CyIUnnh5rRWGyffmZaFc Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Dec 2, 2022 at 10:56 AM, Michael Opdenacker wrote:
Hi Tomasz
Hi
Thanks for the patches!

On 12/1/22 09:24, tomzy wrot= e:
Install uefi-firmware-parser tool

The UEFI firmware = parseer is a simple module and set of scripts for
parsing, extracting,= and recreating UEFI firmware volumes.

Signed-off-by: Tomasz =C5= =BByjewski <tomasz.zyjewski@3mdeb.com>
---
.../python/pytho= n3-uefi-firmware_1.9.bb | 17 +++++++++++++++++
1 file changed, 17 inse= rtions(+)
create mode 100644 meta-python/recipes-devtools/python/pytho= n3-uefi-firmware_1.9.bb
However, if I apply your patch through "git am", the author of the
co= mmit will be:
tomzy <tomasz.zyjewski@3mdeb.com>
instead of<= br />Tomasz =C5=BByjewski <tomasz.zyjewski@3mdeb.com>

Beca= use of this issue, the maintainer has to manually fix this field
when= accepting your patch. Worse, if he doesn't catch this, that's
harder= to fix afterwards.
I was not aware of this issue. I must have missed it in guidelines. Sorry f= or that!
You should be able to fix this by running:
git config --gl= obal sendemail.from "tomasz.zyjewski@3mdeb.com"

This should add = a "From" field to the sent patch which "git am" should
be able to mat= ch with your name.
See
https://www.openembedded.org/wiki/How_to_su= bmit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Co= uld you try to send an update (don't hesitate to send a private one to
me first)?
Thank you, I will try that. Should I use `michael.opdenacker@bootlin.com` ?=

Thanks in advance
Michael.

--
Micha= el Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://boot= lin.com
--CyIUnnh5rRWGyffmZaFc--