From: David Daney <ddaney@caviumnetworks.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.
Date: Thu, 08 Jan 2009 12:49:18 -0800 [thread overview]
Message-ID: <496666CE.3050205@caviumnetworks.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0901081227360.3283@localhost.localdomain>
Linus Torvalds wrote:
[...]
> In fact, I think it already is a no-op in the UP case, and you can
> literally just do
>
> static inline void __init init_irq_default_affinity(void)
> {
> alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
> cpumask_setall(irq_default_affinity);
> }
>
> and be done with it. I think it should all compile away to nothing if
> CONFIG_SMP isn't set.
The 'inline' seems gratuitous to me. Since it is static GCC should do
the Right Thing. However since you suggested it, I am testing it that way.
David Daney
next prev parent reply other threads:[~2009-01-08 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:21 [PATCH] cpumask fallout: Initialize irq_default_affinity earlier David Daney
2009-01-08 20:33 ` Linus Torvalds
2009-01-08 20:49 ` David Daney [this message]
2009-01-08 20:56 ` Linus Torvalds
2009-01-10 5:11 ` Rusty Russell
2009-01-08 21:25 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496666CE.3050205@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.