From: Anthony Liguori <anthony@codemonkey.ws>
To: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Cc: markmc@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6247] Add 'set_link' monitor command (Mark McLoughlin)
Date: Thu, 08 Jan 2009 18:41:23 -0600 [thread overview]
Message-ID: <49669D33.3060208@codemonkey.ws> (raw)
In-Reply-To: <20090109001951.GA29388@edgar.se.axis.com>
Edgar E. Iglesias wrote:
> Hello,
>
> I ran into an issue here with the etrax boards. set_link does not
> handle multiple nics on the same vlan
> I'd like to apply the following soon unless someone objects.
>
Looks good to me.
Regards,
Anthony Liguori
> Best regards
>
> diff --git a/net.c b/net.c
> index fa9fa94..0bb38e4 100644
> --- a/net.c
> +++ b/net.c
> @@ -1703,7 +1703,8 @@ int do_set_link(const char *name, const char *up_or_down)
> for (vlan = first_vlan; vlan != NULL; vlan = vlan->next)
> for (vc = vlan->first_client; vc != NULL; vc = vc->next)
> if (strcmp(vc->name, name) == 0)
> - break;
> + goto done;
> +done:
>
> if (!vc) {
> term_printf("could not find network device '%s'", name);
>
prev parent reply other threads:[~2009-01-09 0:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 19:44 [Qemu-devel] [6247] Add 'set_link' monitor command (Mark McLoughlin) Anthony Liguori
2009-01-09 0:19 ` Edgar E. Iglesias
2009-01-09 0:25 ` Edgar E. Iglesias
2009-01-09 0:41 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49669D33.3060208@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=edgar.iglesias@axis.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.