Re: [PATCH] Make possible speeds known to ethtool

[Jeff Garzik <jgarzik@pobox.com>]

Herbert Xu wrote:
> On Thu, Jan 08, 2009 at 03:12:01AM +0000, Jeff Garzik wrote:
>> The next release of ethtool is coming in about 4 weeks, and we can  
>> definitely get something like this in there.
> 
> Jeff, any chance you can stick this patch in there to add the GRO
> toggle?
> 
> ethtool: Add GRO toggle
> 
> This patch adds the -k toggles to query and set GRO on a device.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index eadba25..3ca4e2c 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -336,6 +336,8 @@ struct ethtool_rxnfc {
>  
>  #define	ETHTOOL_GRXFH		0x00000029 /* Get RX flow hash configuration */
>  #define	ETHTOOL_SRXFH		0x0000002a /* Set RX flow hash configuration */
> +#define	ETHTOOL_GGRO		0x0000002b /* Get GRO enable (ethtool_value) */
> +#define	ETHTOOL_SGRO		0x0000002c /* Set GRO enable (ethtool_value) */

Ugh...  is it too late to change this interface?

The person who added this should have used the new flags interface, and 
added ETH_FLAG_GRO right next to the pre-existing ETH_FLAG_LRO.

It is incorrect to add new ioctls just to toggle a boolean value.

	Jeff