Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions

[Avi Kivity <avi@redhat.com>]

Amit Shah wrote:
> On Sun, Jan 11, 2009 at 12:46:49PM +0200, Avi Kivity wrote:
>   
>> Amit Shah wrote:
>>     
>>> The CPUID instruction takes the value of ECX as an input parameter
>>> in addition to the value of EAX for function 4. Make sure we pass
>>> the value to the instruction.
>>>
>>>   
>>>       
>> This needs to go to upstream qemu.  I'd suggest adding a new parameter  
>> rather than making ecx an in/out parameter.
>>     
>
> You mean something like
>
> host_cpuid(index, subindex, eax, ebx, ecx, edx);
>
> ?
>
>   

Yes.

>> I'd expect a loop when we use this...
>>     
>
> Why a loop? We'll only return the values true for a particular EAX:ECX
> combination. The requestor (kernel) will loop.
>   

The kernel doesn't call host_cpuid().  We preload all possible 
combinations of eax and ecx in advance.

-- 
error compiling committee.c: too many arguments to function