From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: netfilter: ct_extend: alloc space for xt_portscan
Date: Mon, 12 Jan 2009 05:07:08 +0100 [thread overview]
Message-ID: <496AC1EC.1070006@trash.net> (raw)
In-Reply-To: <496633BF.7060609@netfilter.org>
Pablo Neira Ayuso wrote:
> Jan Engelhardt wrote:
>> parent b58602a4bac012b5f4fc12fe6b46ab237b610d5d
>> commit 7634e5f586394eafc85973712ff11e60a9ae2f70
>> Author: Jan Engelhardt <jengelh@medozas.de>
>> Date: Thu Jan 8 09:20:03 2009 +0100
>>
>> netfilter: ct_extend: alloc space for xt_portscan
>>
>> The out-of-tree xt_portscan module currently (ab)uses skb->mark and
>> nfct->mark to store its state, but such may collide with
>> user-specified marks.
>>
>> Using nfct_extend alleviates that problem and hopefully paves way
>> for inclusion of the module.
>>
>
> Sorry, I would not reserve an entry unless I know what xt_portscan is.
I feel the same way. And I would like to know why it needs
connection state. That seems counterintuitive to a portscan
detector, which is by definition trying to detect something
happening in multiple connections.
next prev parent reply other threads:[~2009-01-12 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:24 netfilter: ct_extend: alloc space for xt_portscan Jan Engelhardt
2009-01-08 17:11 ` Pablo Neira Ayuso
2009-01-12 4:07 ` Patrick McHardy [this message]
2009-01-12 4:16 ` Jan Engelhardt
2009-01-12 4:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496AC1EC.1070006@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.