Jan Engelhardt wrote: >>> On Wed, 2008-12-31 at 17:00 -0500, Matt Cross wrote: >>>> I think the work to move ebtables to use xtables broke ebtables. >>>> Specifically, in commit 8cc784eec6676b58e7f60419c88179aaa97bf71c the >>>> return value of the match functions was inverted so that they return 1 >>>> (true) on matches instead of EBT_MATCH (0), and vice versa (look in >>>> ebt_ip.c). The logic in ebtables.c (ebt_do_table() and >>>> EBT_MATCH_ITERATE()) expect match functions to return 0 for matches. >>>> >> Jan, could you have a look at this please? > > That seemds indeed so. > Patch is both for 2.6.29-running and 2.6.28. > > netfilter: ebtables: fix inversion in match code Applied, thanks. When fixing regressions please state the commit ID and subject of the patch introducing the breakage and also who reported it. Like this.