Re: [PATCH] Make errors printed from scsi_sysfs_add_sdev() mean something.

[Hannes Reinecke <hare@suse.de>]

Hi Michal,

Michał Mirosław wrote:
> This is an updated version of patch I wrote long time ago, but looks like
> it didn't get far. Patch against linux-2.6.git. And yes - printk() lines
> are longer than 80 chars - it shouldn't matter here (grep is happy ;).
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> 
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 93c28f3..7a3389c 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -872,12 +872,12 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
>  	error = device_add(&sdev->sdev_gendev);
>  	if (error) {
>  		put_device(sdev->sdev_gendev.parent);
> -		printk(KERN_INFO "error 1\n");
> +		printk(KERN_ERR "sysfs: SCSI device registration failed: %d\n", error);
Shouldn't that be sdev_printk()?

>  		return error;
>  	}
>  	error = device_add(&sdev->sdev_dev);
>  	if (error) {
> -		printk(KERN_INFO "error 2\n");
> +		printk(KERN_ERR "sysfs: SCSI class device registration failed: %d\n", error);
Same here ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html