From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Pavlic Subject: Re: [PATCH] Update bash completions to prevent unbound variable errors. Date: Mon, 12 Jan 2009 16:51:44 -0500 Message-ID: <496BBB70.5090803@tedpavlic.com> References: <496BA0E4.2040607@tedpavlic.com> <200901121435.35547.bss@iguanasuicide.net> <496BB204.2040109@tedpavlic.com> <496BB442.90107@tedpavlic.com> <20090112213213.GM10179@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Boyd Stephen Smith Jr." , git To: "Shawn O. Pearce" X-From: git-owner@vger.kernel.org Mon Jan 12 22:53:18 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LMUid-0001aZ-DE for gcvg-git-2@gmane.org; Mon, 12 Jan 2009 22:53:11 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbZALVvq (ORCPT ); Mon, 12 Jan 2009 16:51:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753377AbZALVvq (ORCPT ); Mon, 12 Jan 2009 16:51:46 -0500 Received: from gallifrey.ece.ohio-state.edu ([164.107.167.66]:47610 "EHLO gallifrey.ece.ohio-state.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753272AbZALVvp (ORCPT ); Mon, 12 Jan 2009 16:51:45 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id 2259D80D802F; Mon, 12 Jan 2009 16:46:03 -0500 (EST) X-Virus-Scanned: amavisd-new at gallifrey.ece.ohio-state.edu Received: from gallifrey.ece.ohio-state.edu ([127.0.0.1]) by localhost (gallifrey.ece.ohio-state.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dh4ZtyroDEM7; Mon, 12 Jan 2009 16:46:03 -0500 (EST) Received: from tedbook.mshome.net (tedpc.ece.ohio-state.edu [164.107.164.122]) by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id 068FA80D8022; Mon, 12 Jan 2009 16:46:03 -0500 (EST) User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051201 Thunderbird/1.5 Mnenhy/0.7.3.0 In-Reply-To: <20090112213213.GM10179@spearce.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: >> It appears like they use >> >> complete -o bashdefault >> >> whereas Git's uses >> >> complete -o default >> >> I think that's the difference. > > If that's all we need to do, that's a simple 1 line change... which > I like. That was a red herring. The problem is more fundamental than that. The script needs to be more careful about its use. I'll submit a better patch momentarily. --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS.