From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Pavlic Subject: Re: [PATCH] Simple update to bash completions to prevent unbound variable errors. Date: Mon, 12 Jan 2009 23:34:40 -0500 Message-ID: <496C19E0.6060308@tedpavlic.com> References: <496C0003.7040909@tedpavlic.com> <7vy6xfew2n.fsf@gitster.siamese.dyndns.org> <200901122157.03658.bss@iguanasuicide.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , "Shawn O. Pearce" , git To: "Boyd Stephen Smith Jr." X-From: git-owner@vger.kernel.org Tue Jan 13 05:36:08 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LMb0Z-0004z1-B5 for gcvg-git-2@gmane.org; Tue, 13 Jan 2009 05:36:07 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbZAMEeo (ORCPT ); Mon, 12 Jan 2009 23:34:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753876AbZAMEen (ORCPT ); Mon, 12 Jan 2009 23:34:43 -0500 Received: from gallifrey.ece.ohio-state.edu ([164.107.167.66]:38825 "EHLO gallifrey.ece.ohio-state.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816AbZAMEen (ORCPT ); Mon, 12 Jan 2009 23:34:43 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id 74C3A80D802F; Mon, 12 Jan 2009 23:29:00 -0500 (EST) X-Virus-Scanned: amavisd-new at gallifrey.ece.ohio-state.edu Received: from gallifrey.ece.ohio-state.edu ([127.0.0.1]) by localhost (gallifrey.ece.ohio-state.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bv3VvJLlVe8l; Mon, 12 Jan 2009 23:29:00 -0500 (EST) Received: from TedBook.local (cpe-76-181-62-78.columbus.res.rr.com [76.181.62.78]) by gallifrey.ece.ohio-state.edu (Postfix) with ESMTP id 1851980D8022; Mon, 12 Jan 2009 23:28:59 -0500 (EST) User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051201 Thunderbird/1.5 Mnenhy/0.7.3.0 In-Reply-To: <200901122157.03658.bss@iguanasuicide.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: > While I dislike emacs and use vim pretty much exclusively, I don't really see > the need for a vim modeline. On top of that, fdm=marker is a bit silly since > there aren't any markers. ff=unix and ft=sh are redundant, as any vim should > detect these properly, given the filename. Without the modeline, the vim I was using didn't set ft=sh. It seemed like the original authors were careful to use tabs everywhere, which was the major reason I used the modeline. I added the fdm=marker just in case someone would want to clean up the code someday and do some folding. > So, I'm slightly negative on the modeline hunk. It was just a suggestion. >> local one=${1-} two=${2-} cur=${3-} four=${4-} > > Even better to use variable names that match the usage, if possible. I don't know much about bash completion. It would be nice if the original authors could add some semantics, as I was just trying to come up with scripts that would actually work with set -u. --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS.