All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Updated initialization script, testers wanted
Date: Tue, 13 Jan 2009 08:02:33 +0000	[thread overview]
Message-ID: <496C4A99.2010608@redhat.com> (raw)
In-Reply-To: <20090112140236.6b74302e@hyperion.delvare>



Jean Delvare wrote:
> Hi Hans,
> 
> I have implemented and committed the sensors-detect side of ticket
> #2246. Now the lm_sensors initialization script needs to be updated as
> well, to make use of the new configuration file syntax. The
> initialization script in our repository is meant for Red Hat
> distributions but I don't have any, so I can't test my changes. The
> patch I intend to apply is attached, could you (or anyone with a Red
> Hat distribution) give it a try and confirm that it works OK?
> Beforehand, you'll need to download and run the latest version of
> sensors-detect:
> 
> http://www.lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0/prog/detect/sensors-detect
> 
> and let it regenerate /etc/sysconfig/lm_sensors.
> 

Erm,

Not tested, I'm not so happy with this change. I've read the ticker trying to 
find out why we would want this change, and I must say I'm not very convinced 
with the reasoning there.

My problem with these changes is that to me it feels like changing the config 
file format without some very strong reasons, this will cause all kind of pains 
when upgrading from an lm_sensors version with the old format to that with the 
new format. Do we really have to do this?

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2009-01-13  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 13:02 [lm-sensors] Updated initialization script, testers wanted Jean Delvare
2009-01-13  8:02 ` Hans de Goede [this message]
2009-01-13 11:11 ` Jean Delvare
2009-01-13 18:45 ` Hans de Goede
2009-01-14 14:28 ` Jean Delvare
2009-01-25  1:28 ` Volker Kuhlmann
2009-01-25 13:47 ` Hans de Goede
2009-01-26 14:24 ` Jean Delvare
2009-02-02 13:27 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496C4A99.2010608@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.