From: "H. Peter Anvin" <hpa@zytor.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Sam Ravnborg <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>,
Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Subject: Re: [PATCH -tip] x86: headers - fix export private data to userspace
Date: Tue, 13 Jan 2009 10:49:24 -0800 [thread overview]
Message-ID: <496CE234.2070900@zytor.com> (raw)
In-Reply-To: <1231871832.16221.1.camel@brick>
Harvey Harrison wrote:
> On Tue, 2009-01-13 at 21:34 +0300, Cyrill Gorcunov wrote:
>> Impact: cleanup
>
>> 4) setup.h - COMMAND_LINE_SIZE saved for userspace, bootloaders
>> could use it.
>
> Doesn't this need to be (at least) _COMMAND_LINE_SIZE to avoid
> polluting the namespace, not sure it can be changed though as the
> horse is already out of the barn.
No, this is not one of those cases, but it's worth explaining why.
You can introduce symbols into the general namespace if *and only if*
they are in a header file that is invoked directly by the user. In
other words, such a header file is unusable by libc, but setup.h doesn't
contain anything needed by libc in the first place.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-01-13 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 18:34 [PATCH -tip] x86: headers - fix export private data to userspace Cyrill Gorcunov
2009-01-13 18:37 ` Harvey Harrison
2009-01-13 18:49 ` H. Peter Anvin [this message]
2009-01-13 18:52 ` Cyrill Gorcunov
2009-01-13 18:55 ` H. Peter Anvin
2009-01-13 19:00 ` Cyrill Gorcunov
2009-01-13 19:03 ` H. Peter Anvin
2009-01-13 19:12 ` Cyrill Gorcunov
2009-01-13 19:05 ` Harvey Harrison
2009-01-13 18:50 ` Cyrill Gorcunov
2009-01-13 18:54 ` H. Peter Anvin
2009-01-13 18:56 ` Cyrill Gorcunov
2009-01-14 19:42 ` H. Peter Anvin
2009-01-14 19:49 ` Cyrill Gorcunov
2009-01-14 20:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496CE234.2070900@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.