From: Sam Vilain <sam@vilain.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Anders Melchiorsen <mail@cup.kalibalik.dk>,
git@vger.kernel.org, jnareb@gmail.com
Subject: Re: [PATCH] gitweb: recognize six digit abbreviated SHA1
Date: Wed, 14 Jan 2009 13:33:33 +1300 [thread overview]
Message-ID: <496D32DD.9010303@vilain.net> (raw)
In-Reply-To: <7vd4erd32a.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> When people give an abbreviated object name, 99% of the time they mean
> commits (and "index deadbeef..acebead" in a patch is a good place to pick
> blob object names from, which would be what the 99% of the remaining 1%
> would name), so making sure it is a commit or a blob would be a very
> sensible thing to do.
>
> Unfortunately, you fundamentally cannot do this without taking a
> performance hit of actually opening the object.
>
Yeah. I envisioned this just for those cases where the tool would
otherwise return 'ambiguous argument'; if there was a hint as to the
object type, open *all* the matching objects and return the one that
matched the type only.
Sam.
prev parent reply other threads:[~2009-01-14 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 0:04 [PATCH] gitweb: recognize six digit abbreviated SHA1 Anders Melchiorsen
2009-01-13 0:08 ` Anders Melchiorsen
2009-01-13 2:00 ` Sam Vilain
2009-01-13 8:26 ` Junio C Hamano
2009-01-14 0:33 ` Sam Vilain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496D32DD.9010303@vilain.net \
--to=sam@vilain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=mail@cup.kalibalik.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.