From: Timur Tabi <timur@freescale.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: linuxppc-dev@ozlabs.org, dan.j.williams@intel.com
Subject: Re: [PATCH] fsldma: print correct IRQ on mpc83xx
Date: Wed, 14 Jan 2009 10:10:45 -0600 [thread overview]
Message-ID: <496E0E85.7060801@freescale.com> (raw)
In-Reply-To: <1231944284-18296-1-git-send-email-jacmet@sunsite.dk>
Peter Korsgaard wrote:
> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct fsl_dma_device *fdev,
> }
>
> dev_info(fdev->dev, "#%d (%s), irq %d\n", new_fsl_chan->id,
> - compatible, new_fsl_chan->irq);
> + compatible,
> + new_fsl_chan->irq != NO_IRQ ? new_fsl_chan->irq : fdev->irq);
Wouldn't it be better to make sure that, on 83xx, new_fsl_chan->irq has the same
value as fdev->irq before we get here?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-01-14 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:44 [PATCH] fsldma: print correct IRQ on mpc83xx Peter Korsgaard
2009-01-14 16:10 ` Timur Tabi [this message]
2009-01-14 16:15 ` Peter Korsgaard
2009-01-14 16:30 ` Timur Tabi
2009-01-14 16:38 ` Peter Korsgaard
2009-01-14 16:42 ` Timur Tabi
2009-01-14 19:29 ` Peter Korsgaard
2009-01-14 19:30 ` Timur Tabi
2009-01-15 6:17 ` Dan Williams
2009-01-15 11:21 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E0E85.7060801@freescale.com \
--to=timur@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=jacmet@sunsite.dk \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.