From: Bryn M. Reeves <bmr@redhat.com>
To: lvm-devel@redhat.com
Subject: lvresize.c: use kilobytes when passing sizes to fsadm
Date: Wed, 14 Jan 2009 17:26:04 +0000 [thread overview]
Message-ID: <496E202C.1060009@redhat.com> (raw)
Hi all,
The code in lvresize.c computes a new file system size to pass to
fsadm when resizing as (extents * extent_size), giving a result in
kilobytes.
This is then passed on to fsadm without a suffix, meaning that fsadm
interprets it as a count of the number of file system blocks instead.
This breaks fsadm for all file system block sizes other than 1K.
The attached patch adds a "K" suffix and fixes the problem for me - see:
https://bugzilla.redhat.com/show_bug.cgi?id=480022
For testing details.
Regards,
Bryn.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lvm2-lvresize-units.patch
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090114/26d3d877/attachment.ksh>
next reply other threads:[~2009-01-14 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 17:26 Bryn M. Reeves [this message]
2009-01-15 13:22 ` lvresize.c: use kilobytes when passing sizes to fsadm Milan Broz
2009-01-15 13:39 ` Bryn M. Reeves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E202C.1060009@redhat.com \
--to=bmr@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.