From: Mike Rapoport <mike@compulab.co.il>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@sirena.org.uk>,
Samuel Ortiz <sameo@openedhand.com>,
felipe.balbi@nokia.com, Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver.
Date: Thu, 15 Jan 2009 08:34:30 +0200 [thread overview]
Message-ID: <496ED8F6.6030201@compulab.co.il> (raw)
In-Reply-To: <f17812d70901141704n1ac3e8a7q56410f175b833ef6@mail.gmail.com>
Eric Miao wrote:
> On Thu, Jan 15, 2009 at 2:16 AM, Jonathan Cameron <jic23@cam.ac.uk> wrote:
>> From: Jonathan Cameron <jic23@cam.ac.uk>
>>
>> Add support for changing the mode of the da9030 usb charge pump
>>
>
> Well, if it is totally USB charger related, I'd suggest to move this into
> the dedicated driver. This mfd/da903x.c serves as a common code
> base for all sub-peripherals.
It's not exactly related to the charger, it's rather related to the USB voltage
supplied to USB devices attached to PXA OHCI.
Indeed the mfd/da903x.c serves as a common core for sub-peripherals, but IMHO
adding a subdevice driver because of single method doesn't worth the overhead.
I'm for the solution Jonathan proposes.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2009-01-15 6:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 18:16 [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver Jonathan Cameron
2009-01-15 1:04 ` Eric Miao
2009-01-15 6:34 ` Mike Rapoport [this message]
2009-01-15 7:02 ` Eric Miao
2009-01-15 7:28 ` Mike Rapoport
2009-01-15 8:13 ` Eric Miao
2009-01-15 11:22 ` Jonathan Cameron
2009-01-15 13:02 ` Mark Brown
2009-01-15 13:31 ` Jonathan Cameron
2009-01-15 18:36 ` Mark Brown
2009-01-15 6:38 ` Mike Rapoport
2009-01-15 11:11 ` Jonathan Cameron
2009-01-15 11:23 ` Mike Rapoport
2009-01-15 11:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496ED8F6.6030201@compulab.co.il \
--to=mike@compulab.co.il \
--cc=broonie@sirena.org.uk \
--cc=eric.y.miao@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.