diff for duplicates of <496EEE6D.6090300@openwrt.org> diff --git a/a/1.txt b/N1/1.txt index 78259d9..bf0492f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,39 +1,47 @@ -Sujith ?rta: +Sujith =EDrta: > Gabor Juhos wrote: ->> +static bool ath_ahb_eeprom_read(struct ath_hal *ah, u32 off, u16 *data) +>> +static bool ath_ahb_eeprom_read(struct ath_hal *ah, u32 off, u16 *d= +ata) >> +{ ->> + struct ath_softc *sc = ah->ah_sc; ->> + struct platform_device *pdev = to_platform_device(sc->dev); +>> + struct ath_softc *sc =3D ah->ah_sc; +>> + struct platform_device *pdev =3D to_platform_device(sc->dev); >> + struct ath9k_platform_data *pdata; >> + ->> + pdata = (struct ath9k_platform_data *) pdev->dev.platform_data; ->> + if (off >= (ARRAY_SIZE(pdata->eeprom_data))) { +>> + pdata =3D (struct ath9k_platform_data *) pdev->dev.platform_data; +>> + if (off >=3D (ARRAY_SIZE(pdata->eeprom_data))) { >> + DPRINTF(ah->ah_sc, ATH_DBG_FATAL, >> + "%s: flash read failed, offset %08x is out of range\n", >> + __func__, off); >> + return false; >> + } >> + ->> + *data = pdata->eeprom_data[off]; +>> + *data =3D pdata->eeprom_data[off]; >> + return true; >> +} >> + -> +>=20 > Shouldn't pdev->dev.platform_data be initalized somewhere ? It must be initialized by the board specific setup code, -> @@ -48,6 +69,12 @@ static int ath_ahb_probe(struct platform_device *pdev) -> int ret = 0; +> @@ -48,6 +69,12 @@ static int ath_ahb_probe(struct platform_device *p= +dev) +> int ret =3D 0; > struct ath_hal *ah; -> +> =20 > + if (!pdev->dev.platform_data) { > + dev_err(&pdev->dev, "no platform data specified\n"); -> + ret = -EINVAL; +> + ret =3D -EINVAL; > + goto err_out; > + } > + -... and we have checked it in the probe routine anyway. +=2E.. and we have checked it in the probe routine anyway. -Gabor + +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireles= +s" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 6a5f1e7..5ce41b5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,49 +2,63 @@ "ref\01231960632-4452-8-git-send-email-juhosg@openwrt.org\0" "ref\018798.41971.397753.279649@localhost.localdomain\0" "From\0Gabor Juhos <juhosg@openwrt.org>\0" - "Subject\0[ath9k-devel] [PATCH v4 07/11] ath9k: get EEPROM contents from platform data on AHB bus\0" + "Subject\0Re: [ath9k-devel] [PATCH v4 07/11] ath9k: get EEPROM contents from platform data on AHB bus\0" "Date\0Thu, 15 Jan 2009 09:06:05 +0100\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Sujith <m.sujith@gmail.com>\0" + "Cc\0John W. Linville <linville@tuxdriver.com>" + ath9k-devel@lists.ath9k.org <ath9k-devel@venema.h4ckr.net> + linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org> + Jouni Malinen <jmalinen@atheros.com> + Christoph Hellwig <hch@infradead.org> + " Johannes Berg <johannes@sipsolutions.net>\0" "\00:1\0" "b\0" - "Sujith ?rta:\n" + "Sujith =EDrta:\n" "> Gabor Juhos wrote:\n" - ">> +static bool ath_ahb_eeprom_read(struct ath_hal *ah, u32 off, u16 *data)\n" + ">> +static bool ath_ahb_eeprom_read(struct ath_hal *ah, u32 off, u16 *d=\n" + "ata)\n" ">> +{\n" - ">> +\tstruct ath_softc *sc = ah->ah_sc;\n" - ">> +\tstruct platform_device *pdev = to_platform_device(sc->dev);\n" + ">> +\tstruct ath_softc *sc =3D ah->ah_sc;\n" + ">> +\tstruct platform_device *pdev =3D to_platform_device(sc->dev);\n" ">> +\tstruct ath9k_platform_data *pdata;\n" ">> +\n" - ">> +\tpdata = (struct ath9k_platform_data *) pdev->dev.platform_data;\n" - ">> +\tif (off >= (ARRAY_SIZE(pdata->eeprom_data))) {\n" + ">> +\tpdata =3D (struct ath9k_platform_data *) pdev->dev.platform_data;\n" + ">> +\tif (off >=3D (ARRAY_SIZE(pdata->eeprom_data))) {\n" ">> +\t\tDPRINTF(ah->ah_sc, ATH_DBG_FATAL,\n" ">> +\t\t\t\"%s: flash read failed, offset %08x is out of range\\n\",\n" ">> +\t\t\t\t__func__, off);\n" ">> +\t\treturn false;\n" ">> +\t}\n" ">> +\n" - ">> +\t*data = pdata->eeprom_data[off];\n" + ">> +\t*data =3D pdata->eeprom_data[off];\n" ">> +\treturn true;\n" ">> +}\n" ">> +\n" - "> \n" + ">=20\n" "> Shouldn't pdev->dev.platform_data be initalized somewhere ?\n" "\n" "It must be initialized by the board specific setup code,\n" "\n" - "> @@ -48,6 +69,12 @@ static int ath_ahb_probe(struct platform_device *pdev)\n" - "> \tint ret = 0;\n" + "> @@ -48,6 +69,12 @@ static int ath_ahb_probe(struct platform_device *p=\n" + "dev)\n" + "> \tint ret =3D 0;\n" "> \tstruct ath_hal *ah;\n" - "> \n" + "> =20\n" "> +\tif (!pdev->dev.platform_data) {\n" "> +\t\tdev_err(&pdev->dev, \"no platform data specified\\n\");\n" - "> +\t\tret = -EINVAL;\n" + "> +\t\tret =3D -EINVAL;\n" "> +\t\tgoto err_out;\n" "> +\t}\n" "> +\n" "\n" - "... and we have checked it in the probe routine anyway.\n" + "=2E.. and we have checked it in the probe routine anyway.\n" "\n" - -Gabor + "-Gabor\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" + "s\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -09d51dd5bfb9201bd5955dd83e599faf120dcdde6f185000c1e774cbc75bf367 +3eb473d67fcfa4ac40b6c5edd5014bab7486ad07a33329401cb3203408ac7396
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.