From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd Date: Thu, 15 Jan 2009 11:54:09 +0200 Message-ID: <496F07C1.6050605@redhat.com> References: <1231951270-23664-1-git-send-email-amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38529 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756121AbZAOJyQ (ORCPT ); Thu, 15 Jan 2009 04:54:16 -0500 In-Reply-To: <1231951270-23664-1-git-send-email-amit.shah@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > These patches add support for cpuid functions that take a 'count' parameter > in addition to the function number. With these patches, KVM can run a VM > started with a newer CPU type (coreduo, core2duo). These patches also pave > way for a "host" CPU type, where we could pass the CPU type of the current > host to the VM. > > v3 uses the as-yet unused KVM_SET_CPUID2 interface, which was written to > support this functionality. Since we rely on kernel versions 2.6.25 at a > minimum for KVM and the SET_CPUID2 interface was introduced in 2.6.25, we're > safe with this. > > Looks good. Note that function 2 also needs special treatment. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNOvZ-000759-KG for qemu-devel@nongnu.org; Thu, 15 Jan 2009 04:54:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNOvX-00073r-VO for qemu-devel@nongnu.org; Thu, 15 Jan 2009 04:54:17 -0500 Received: from [199.232.76.173] (port=36290 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNOvX-00073W-OS for qemu-devel@nongnu.org; Thu, 15 Jan 2009 04:54:15 -0500 Received: from mx2.redhat.com ([66.187.237.31]:39411) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNOvX-000505-A9 for qemu-devel@nongnu.org; Thu, 15 Jan 2009 04:54:15 -0500 Message-ID: <496F07C1.6050605@redhat.com> Date: Thu, 15 Jan 2009 11:54:09 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1231951270-23664-1-git-send-email-amit.shah@redhat.com> In-Reply-To: <1231951270-23664-1-git-send-email-amit.shah@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Amit Shah wrote: > These patches add support for cpuid functions that take a 'count' parameter > in addition to the function number. With these patches, KVM can run a VM > started with a newer CPU type (coreduo, core2duo). These patches also pave > way for a "host" CPU type, where we could pass the CPU type of the current > host to the VM. > > v3 uses the as-yet unused KVM_SET_CPUID2 interface, which was written to > support this functionality. Since we rely on kernel versions 2.6.25 at a > minimum for KVM and the SET_CPUID2 interface was introduced in 2.6.25, we're > safe with this. > > Looks good. Note that function 2 also needs special treatment. -- error compiling committee.c: too many arguments to function