From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/2] ioemu: initialize vram area to 0xff
Date: Thu, 15 Jan 2009 12:49:08 +0000
Message-ID: <496F30C4.1010702@eu.citrix.com>
References: <20090115122455.GY1565%yamahata@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090115122455.GY1565%yamahata@valinux.co.jp>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: samuel.thibault@ens-lyon.org, xen-devel@lists.xensource.com, ian.jackson@eu.citrix.com, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Isaku Yamahata wrote:

> +
> +    xen_vga_vram_map(vram_addr, vga_ram_size);
> +
> +    /* Win2K seems to assume that the pattern buffer is at 0xff
> +       initially ! */
> +    memset(xen_vga_state->vram_ptr, 0xff, vga_ram_size);


Are you sure that this is really needed?
Isn't the Bios supposed to take care of that?

> +    /* If some display is already working, we need to update it now */
> +    ds= xen_vga_state->ds;
> +    if (ds)
> +        dpy_update(ds, 0,0, ds->width,ds->height);


I don't think this is needed as well: xen_vga_vram_map is called either
during the initialization state or when loading the vm state file.
At both points the display shouldn't need any update.