All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Jonathan Cameron <Jonathan.Cameron@gmail.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	Mike Rapoport <mike@compulab.co.il>,
	LKML <linux-kernel@vger.kernel.org>,
	Samuel Ortiz <sameo@openedhand.com>,
	felipe.balbi@nokia.com, Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver.
Date: Thu, 15 Jan 2009 13:31:43 +0000	[thread overview]
Message-ID: <496F3ABF.1020201@cam.ac.uk> (raw)
In-Reply-To: <20090115130230.GG2147@sirena.org.uk>

Mark Brown wrote:
> ")
> Fcc: +sent-mail
> 
> On Thu, Jan 15, 2009 at 11:22:34AM +0000, Jonathan Cameron wrote:
> 
>>> I would expect the final solution to be clean enough, that requires some
>>> dependent stuffs to be modified, and the final look of this patch may be a
>>> bit different
> 
>> Agreed.  This definitely isn't the way to go in the long run (assuming
>> otg etc get cleaned up)
>> but would it be an acceptable stop gap?  I'm just keen to get the
>> functionality available
>> so as to get a board config (intel stargate 2) sorted.  (some of which
>> you were kind enough to
>> review a while back - thanks).
> 
> Having looked at this problem just this week for some other designs I'm
> thinking the regulator API might be a good fit for this.  It is a supply
> and the API provides a method to match up the supply with the USB
> controller (some designs have multiple options there so that's useful).
> I've not actually tried it yet to see what the pain is like, though.
I did at one point.  The problem here is you aren't simply controlling the
current / voltage. You are switching it between various automatic modes
and a manual override.  Only in the manually overridden states is it
much like a regulator and then it's one with very odd properties.

If these are consistent enough across different pmic's I guess it could
be blugeoned in, but I'm not convinced this is true.

Jonathan



 


  reply	other threads:[~2009-01-15 13:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 18:16 [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver Jonathan Cameron
2009-01-15  1:04 ` Eric Miao
2009-01-15  6:34   ` Mike Rapoport
2009-01-15  7:02     ` Eric Miao
2009-01-15  7:28       ` Mike Rapoport
2009-01-15  8:13         ` Eric Miao
2009-01-15 11:22           ` Jonathan Cameron
2009-01-15 13:02             ` Mark Brown
2009-01-15 13:31               ` Jonathan Cameron [this message]
2009-01-15 18:36                 ` Mark Brown
2009-01-15  6:38 ` Mike Rapoport
2009-01-15 11:11   ` Jonathan Cameron
2009-01-15 11:23     ` Mike Rapoport
2009-01-15 11:14   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496F3ABF.1020201@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=Jonathan.Cameron@gmail.com \
    --cc=broonie@sirena.org.uk \
    --cc=eric.y.miao@gmail.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@kernel.org \
    --cc=mike@compulab.co.il \
    --cc=sameo@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.