From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: JosephChan@via.com.tw, linux-ide@vger.kernel.org,
sshtylyov@ru.mvista.com
Subject: Re: [PATCH 2/2 v1] pata_via.c: Patch the behavior of via chipsets.
Date: Thu, 15 Jan 2009 23:54:56 +0900 [thread overview]
Message-ID: <496F4E40.1020402@kernel.org> (raw)
In-Reply-To: <20090115141457.334e36dc@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> Can you please add comments to explain it? Also, it would be nice if
>> you do ap->ctl = ap->last_ctl and turn off ATA_TFLAG_DEVICE to avoid
>> loading them yet again.
>
> I don't think you can turn off ATA_TFLAG_DEVICE, you have no guarantee it
> won't be referred to again anywhere else in the stack - tf->flags isn't
> owned by the driver so its asking for trouble to do that.
The original code copied tf to tmp_tf and turned it off there. New code
can do about the same thing.
--
tejun
next prev parent reply other threads:[~2009-01-15 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 13:05 [PATCH 2/2 v1] pata_via.c: Patch the behavior of via chipsets JosephChan
2009-01-15 13:54 ` Tejun Heo
2009-01-15 14:14 ` Alan Cox
2009-01-15 14:54 ` Tejun Heo [this message]
2009-01-15 14:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496F4E40.1020402@kernel.org \
--to=tj@kernel.org \
--cc=JosephChan@via.com.tw \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.