All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Christian von Roques <roques@mti.ag>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: xtables use of NFPROTO_UNSPEC as wildcard incomplete :-(
Date: Thu, 15 Jan 2009 16:52:57 +0100	[thread overview]
Message-ID: <496F5BD9.2020703@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0901140256180.22699@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Tuesday 2009-01-13 22:38, Christian von Roques wrote:
>> I have a production server where I had to replace a failed on-board
>> Ethernet port with a 3c905 requiring a very new kernel (due to a
>> regression in the 3c905 driver, which was just recently fixed).  This
>> server requires netfilter/xt_MARK.c for IPv4.  Unfortunately your
>> changes to make NFPROTO_UNSPEC act like a protocol wildcard seem
>> incomplete.  -j MARK does not work anymore.  Replacing NFPROTO_UNSPEC
>> with NFPROTO_IPV4 in xt_MARK.c fixed my problem, but obviously
>> disabled the MARK target for all other protocols (which I fortunately
>> don't need).
>>
>> Is this a know problem?
>> Are you able to reproduce the problem?
>> The simplest command which used to fail was:
>> iptables -t mangle -A OUTPUT -j MARK --set-mark 0x14 
> 
> 
> This is probably the same as
> http://marc.info/?l=netfilter&m=123174116204956&w=2 and only
> manifests itself under the condition that kernel < 2.6.28 && iptables
> <= 1.4.0. Most people should-have (read it as a recommendation)
> upgraded their iptables long ago, really, since some distros just
> keep on shipping old stuff like almost forever.

I'm not sure what you mean, the problem that patch fixed affects
kernel == 2.6.28 and all iptables versions as long as you use
anything but revision 0.

Anyways, I'll send the patch to -stable shortly.

      reply	other threads:[~2009-01-15 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87k58yzy2v.fsf@cayenne.mti.ag>
2009-01-14  2:22 ` xtables use of NFPROTO_UNSPEC as wildcard incomplete :-( Jan Engelhardt
2009-01-15 15:52   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496F5BD9.2020703@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=roques@mti.ag \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.