From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH] increase initial memory reservation for stubdom based HVM domains Date: Thu, 15 Jan 2009 17:08:29 +0000 Message-ID: <496F6D8D.9050302@eu.citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 15/01/2009 16:46, "Stefano Stabellini" > wrote: > >> this patch requests 32 additional MB of free RAM from dom0 when an HVM >> domain is started, if the device model for the domain is provided by a >> stubdom. >> This way there is no risk that a stubdom fails to populate the videoram >> because the RAM freed for the videoram by dom0 has already been used to >> create the stubdom. > > Does this mean you're giving up on 'properly' fixing the auto ballooner? :-) > > At least the +32 needs a comment. Perhaps abstraction into a function or > variable as well as a comment. Is the value 32 as arbitrary as it seems? > This fix is not as bad as it seems: I am only increasing the memory freed by the autoballoner when a stubdom based HVM domain is created, in order to also take into account the memory used by the stubdom. In facts 32MB is exactly the size currently needed by a stubdom, it can probably be reduced, but I preferred making one step at a time. The memory actually used to create the HVM domain is still the same as before.