From: David Daney <ddaney@caviumnetworks.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 06/14] MIPS: print irq handler description
Date: Thu, 15 Jan 2009 11:58:49 -0800 [thread overview]
Message-ID: <496F9579.7050300@caviumnetworks.com> (raw)
In-Reply-To: <20090115194921.GB8656@roarinelk.homelinux.net>
Manuel Lauss wrote:
[...]
> Or how about this?
>
[...] seq_printf(p, " %14s", irq_desc[i].chip->name);
> - seq_printf(p, "-%-8s", irq_desc[i].name);
> + if (irq_desc[i].name)
> + seq_printf(p, "-%-8s", irq_desc[i].name);
> seq_printf(p, " %s", action->name);
I will let you and Ralf decide. However it would be nice if
action->name lined up with a mixture of NULL and non-NULL
irq_desc[i].name. It is not clear to me if this is the case with your
patch.
David Daney
next prev parent reply other threads:[~2009-01-15 19:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 8:26 [PATCH 00/14] Alchemy updates v6 Manuel Lauss
2008-12-21 8:26 ` [PATCH 01/14] Alchemy: move development board code to common subdirectory Manuel Lauss
2008-12-21 17:08 ` Ralf Baechle
2008-12-21 18:14 ` Sergei Shtylyov
2008-12-21 8:26 ` [PATCH 02/14] Alchemy: devboards: consolidate files Manuel Lauss
2008-12-21 17:11 ` Ralf Baechle
2008-12-21 8:26 ` [PATCH 03/14] Alchemy: move commandline mangling out of common code Manuel Lauss
2008-12-21 8:26 ` [PATCH 04/14] Alchemy: update core interrupt code Manuel Lauss
2008-12-21 8:26 ` [PATCH 05/14] Alchemy: pb1200: update CPLD cascade irq handler Manuel Lauss
2008-12-21 8:26 ` [PATCH 06/14] MIPS: print irq handler description Manuel Lauss
2009-01-15 19:38 ` David Daney
2009-01-15 19:49 ` Manuel Lauss
2009-01-15 19:58 ` David Daney [this message]
2009-01-15 20:22 ` Manuel Lauss
2009-02-27 14:07 ` Ralf Baechle
2008-12-21 8:26 ` [PATCH 07/14] Alchemy: remove get/set_au1x00_lcd_clock() Manuel Lauss
2008-12-21 8:26 ` [PATCH 08/14] Alchemy: remove cpu_table Manuel Lauss
2008-12-21 8:26 ` [PATCH 09/14] MIPS: make cp0 counter clocksource/event usable as fallback Manuel Lauss
2008-12-21 8:26 ` [PATCH 10/14] Alchemy: RTC counter clocksource / clockevent support Manuel Lauss
2008-12-21 8:26 ` [PATCH 11/14] Alchemy: move calc_clock function Manuel Lauss
2008-12-21 8:26 ` [PATCH 12/14] Alchemy: Fix up PM code on Au1550/Au1200 Manuel Lauss
2008-12-21 8:26 ` [PATCH 13/14] Alchemy: dbdma suspend/resume support Manuel Lauss
2008-12-21 8:26 ` [PATCH 14/14] Alchemy: new userspace suspend interface for development boards Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496F9579.7050300@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.