Re: [Xenomai-core] Pending patches

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]

Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> Jan Kiszka wrote:
>>> Gilles Chanteperdrix wrote:
>>>> Jan Kiszka wrote:
>>>>> commit 028d4766a38b6937d9a2c02a20022e3ee5b67b55
>>>>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>>>>> Date:   Thu Jan 15 11:10:24 2009 +0100
>>>>>
>>>>>     POSIX: Fix initialization of SCHED_RR threads
>>>>>     
>>>>>     Passing SCHED_RR as policy to pthread_create has currently not the
>>>>>     desired effect. The kernel part expects that user space adjusts the
>>>>>     policy and prio via __pse51_thread_setschedparam after setting up the
>>>>>     shadow. And this is what the patch does by calling the wrapped
>>>>>     pthread_setschedparam instead of the real one.
>>>>>     
>>>>>     Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>>>>
>>>>>  src/skins/posix/thread.c |    2 +-
>>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> commit 71666ce04ef216d281fe86ee82a5560c2b57c6dd
>>>>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>>>>> Date:   Thu Jan 15 11:10:24 2009 +0100
>>>>>
>>>>>     Handle priority changes of SCHED_RR tasks
>>>>>     
>>>>>     If shadowed Linux tasks with SCHED_RR policy change their priority,
>>>>>     do_setsched_event currenty ignores this. Extend the condition to catch
>>>>>     this case as well.
>>>>>     
>>>>>     Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>>>>
>>>>>  ksrc/nucleus/shadow.c |    2 +-
>>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>> Nack these two ones too. Philippe implemented a SCHED_RR working over
>>>> aperiodic mode. I think the POSIX skin needs fixing, but not that way.
>>> Then please suggest a better fix.
>> I thought I did: simply pass the SCHED_RR option to kernel-space and
>> handle it there, but replace it with SCHED_FIFO for anything in
>> user-space. I plan to do it, but trunk is not my current priority.
> 
> This is also a stable bug (so the final version should also be
> backported). However, I will check your proposal.

Extending the __pse51_thread_create syscall to also take the sched
policy is likely no option to fix 2.4.x -- ABI breakage...

Suggestion: Apply my original fix to stable but go the enhanced
__pse51_thread_create path for trunk (I'm working on the latter ATM).

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]