[Ocfs2-devel] [PATCH] ocfs2: return f_fsid info in ocfs2_statfs()

[Coly Li <coly.li@suse.de>]

Sunil Mushran Wrote:
> Mark Fasheh wrote:
>> Well, mkfs.ocfs2/tunefs.ocfs2 is supposed to populate it s_uuid_hash
>> based
>> on the *original* uuid of the file system. We don't dynamically
>> calculate it
>> because uuid might change due to a clone operation, which would then
>> break
>> the hashing of that particular file system.
> 
> OK. I missed that bit.
> 
>> Since s_uuid_hash is feature specific, I think perhaps we should just use
>> some part of the uuid, which is always populated. For this, I think we
>> could
>> do the same as the o2cb dlm key (which has to also be pretty unique) -
>> crc32_le(uuid)
> 
> I was thinking the same.

Now I use crc32_le(osb->uuid_str) to generate fsid value. osb->uuid_str is string representation of
s_uuid. Since uuid_str is byte-by-byte, the f_fsid value should be endian consistent.

Would you please to review the v4 patch once more ?

Thanks for your comments.
-- 
Coly Li
SuSE Labs