From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNlZc-00056x-W7 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 05:05:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNlZa-00054Q-Ll for qemu-devel@nongnu.org; Fri, 16 Jan 2009 05:05:08 -0500 Received: from [199.232.76.173] (port=38629 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNlZa-00054F-B9 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 05:05:06 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:15703) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNlZZ-00088y-JN for qemu-devel@nongnu.org; Fri, 16 Jan 2009 05:05:05 -0500 Received: from mail2.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0GA53d0007483 for ; Fri, 16 Jan 2009 11:05:03 +0100 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0GA53OH024976 for ; Fri, 16 Jan 2009 11:05:03 +0100 Message-ID: <49705BD2.9060609@siemens.com> Date: Fri, 16 Jan 2009 11:05:06 +0100 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RESEND][PATCH 2/2] x86: Issue reset on triple faults Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" [ Also available via git://git.kiszka.org/qemu.git queue/assorted ] As discussed a few times on this list: A triple fault causes a system reset on x86, and some guests make use of this (e.g. 386BSD). To keep the chance of tracing unexpected resets, log them if CPU_LOG_RESET is set. Signed-off-by: Jan Kiszka --- target-i386/op_helper.c | 17 +++++++++++++++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c index dcbc361..47f015f 100644 --- a/target-i386/op_helper.c +++ b/target-i386/op_helper.c @@ -1251,6 +1251,9 @@ void do_interrupt(int intno, int is_int, int error_code, } } +/* This should come from sysemu.h - if we could include it here... */ +void qemu_system_reset_request(void); + /* * Check nested exceptions and change to double or triple fault if * needed. It should only be called, if this is not an interrupt. @@ -1267,8 +1270,18 @@ static int check_exception(int intno, int *error_code) qemu_log_mask(CPU_LOG_INT, "check_exception old: 0x%x new 0x%x\n", env->old_exception, intno); - if (env->old_exception == EXCP08_DBLE) - cpu_abort(env, "triple fault"); +#if !defined(CONFIG_USER_ONLY) + if (env->old_exception == EXCP08_DBLE) { + if (env->hflags & HF_SVMI_MASK) + helper_vmexit(SVM_EXIT_SHUTDOWN, 0); /* does not return */ + + if (loglevel & CPU_LOG_RESET) + fprintf(logfile, "Triple fault\n"); + + qemu_system_reset_request(); + return EXCP_HLT; + } +#endif if ((first_contributory && second_contributory) || (env->old_exception == EXCP0E_PAGE &&