[Qemu-devel] Re: [RESEND][PATCH 1/2] Log reset events

[Jan Kiszka <jan.kiszka@siemens.com>]

Laurent Desnogues wrote:
> On Fri, Jan 16, 2009 at 11:05 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> [...]
>> This patch introduces a flag to log CPU resets. Useful for tracing
>> unexpected resets (such as those triggered by x86 triple faults).
> 
> [...]
> 
>> diff --git a/target-arm/helper.c b/target-arm/helper.c
>> index 81663c8..90421bb 100644
>> --- a/target-arm/helper.c
>> +++ b/target-arm/helper.c
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
>>  void cpu_reset(CPUARMState *env)
>>  {
>>     uint32_t id;
>> +
>> +    if (loglevel & CPU_LOG_RESET) {
>> +        fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> +        cpu_dump_state(env, logfile, fprintf, 0);
>> +    }
> 
> You should use the new log API which has been introduced yesterday
> (look in qemu-common.h).
> 

Oh, OK, will check this.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux