From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-mips@linux-mips.org, stable <stable@kernel.org>
Subject: Re: [PATCH] tx4939ide: Do not use zero count PRD entry
Date: Fri, 16 Jan 2009 15:51:29 +0300 [thread overview]
Message-ID: <497082D1.5030504@ru.mvista.com> (raw)
In-Reply-To: <1230215558-9197-1-git-send-email-anemo@mba.ocn.ne.jp>
Hello.
Atsushi Nemoto wrote:
> This fixes data corruption on some heavy load.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> diff --git a/drivers/ide/tx4939ide.c b/drivers/ide/tx4939ide.c
> index bafb7d1..30d0d25 100644
> --- a/drivers/ide/tx4939ide.c
> +++ b/drivers/ide/tx4939ide.c
> @@ -259,6 +259,12 @@ static int tx4939ide_build_dmatable(ide_drive_t *drive, struct request *rq)
> bcount = 0x10000 - (cur_addr & 0xffff);
> if (bcount > cur_len)
> bcount = cur_len;
> + /*
> + * This workaround for zero count seems required.
> + * (standard ide_build_dmatable do it too)
>
s/do/does/
> + */
> + if ((bcount & 0xffff) == 0x0000)
>
Why not just bcount == 0x10000?
MBR, Sergei
next prev parent reply other threads:[~2009-01-16 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 14:32 [PATCH] tx4939ide: Do not use zero count PRD entry Atsushi Nemoto
2008-12-29 18:38 ` Bartlomiej Zolnierkiewicz
2009-01-16 12:51 ` Sergei Shtylyov [this message]
2009-01-16 14:25 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497082D1.5030504@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.