From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935438AbZAPOJ1 (ORCPT ); Fri, 16 Jan 2009 09:09:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932344AbZAPOJK (ORCPT ); Fri, 16 Jan 2009 09:09:10 -0500 Received: from vpn.id2.novell.com ([195.33.99.129]:1982 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933738AbZAPOJJ convert rfc822-to-8bit (ORCPT ); Fri, 16 Jan 2009 09:09:09 -0500 Message-Id: <4970A338.76E4.0078.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.0 Date: Fri, 16 Jan 2009 14:09:44 +0000 From: "Jan Beulich" To: "Ingo Molnar" Cc: , , Subject: Re: [PATCH] x86: fully honor "nolapic" (take 2) References: <4970818A.76E4.0078.0@novell.com> <20090116124548.GC5421@elte.hu> <49709C94.76E4.0078.0@novell.com> <20090116134243.GC14874@elte.hu> <49709EF7.76E4.0078.0@novell.com> <20090116135851.GA7153@elte.hu> In-Reply-To: <20090116135851.GA7153@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Ingo Molnar 16.01.09 14:58 >>> > >* Jan Beulich wrote: > >> >>> Ingo Molnar 16.01.09 14:42 >>> >> > >> >* Jan Beulich wrote: >> > >> >> >>> Ingo Molnar 16.01.09 13:45 >>> >> >> > >> >> >* Jan Beulich wrote: >> >> > >> >> >> + if (disable_apic) { >> >> >> +#ifdef CONFIG_X86_IO_APIC >> >> >> + disable_ioapic_setup(); >> >> >> +#endif >> >> >> + return; >> >> >> + } >> >> > >> >> > Shouldnt that #ifdef be avoided by always providing the function - >> >> > just it is a NOP inline in the !CONFIG_X86_IO_APIC case? >> >> >> >> That would make for a much bigger patch, since the io_apic.h doesn't >> >> (and imo shouldn't) be included without that config option. >> > >> >But we are using io-apic functionality in that file, so we should include >> >io_apic.h, right? >> >> I don't generally (i.e. when !X86_IO_APIC) think so - anything accessing >> stuff from io_apic.c is guarded by a similar #ifdef. > >and wrongly so - it proliferates ugly #ifdefs and sets us up for build >failures like that. Developers cannot be expected to keep every build >option in mind - we should provide an as homogenic and kconfig-invariant >environment as possible. I mostly agree here, but think that this ought to be a separate cleanup patch. Jan