All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Linux NFSv4 mailing list <nfsv4@linux-nfs.org>,
	Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Cc: SystemTAP <systemtap@redhat.com>
Subject: [PATCH 1/5] NFS: Adding trace points to fs/nfs/getroot.c
Date: Fri, 16 Jan 2009 11:25:33 -0500	[thread overview]
Message-ID: <4970B4FD.4000400@RedHat.com> (raw)
In-Reply-To: <4970B451.4080201-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>


Added trace points to nfs_get_root() which define 
when nfs_get_root() is called and if it fails.

Signed-off-by: Steve Dickson <steved@redhat.com>

--- linux/fs/nfs/getroot.c.orig	2008-12-24 18:26:37.000000000 -0500
+++ linux/fs/nfs/getroot.c	2009-01-15 12:42:16.000000000 -0500
@@ -32,6 +32,7 @@
 #include <linux/namei.h>
 #include <linux/mnt_namespace.h>
 #include <linux/security.h>
+#include <trace/nfs.h>
 
 #include <asm/system.h>
 #include <asm/uaccess.h>
@@ -40,6 +41,12 @@
 #include "delegation.h"
 #include "internal.h"
 
+DEFINE_TRACE(nfs_mount_get_root);
+DEFINE_TRACE(nfs_mount_getroot);
+DEFINE_TRACE(nfs_mount_get_root_fhget);
+DEFINE_TRACE(nfs_mount_get_root_dummy_root);
+DEFINE_TRACE(nfs_mount_get_root_alias);
+
 #define NFSDBG_FACILITY		NFSDBG_CLIENT
 
 /*
@@ -84,25 +91,30 @@ struct dentry *nfs_get_root(struct super
 	struct inode *inode;
 	int error;
 
+	trace_nfs_mount_get_root(sb, server, mntfh);
+
 	/* get the actual root for this mount */
 	fsinfo.fattr = &fattr;
 
 	error = server->nfs_client->rpc_ops->getroot(server, mntfh, &fsinfo);
 	if (error < 0) {
 		dprintk("nfs_get_root: getattr error = %d\n", -error);
+		trace_nfs_mount_getroot(sb, server, error);
 		return ERR_PTR(error);
 	}
 
 	inode = nfs_fhget(sb, mntfh, fsinfo.fattr);
 	if (IS_ERR(inode)) {
 		dprintk("nfs_get_root: get root inode failed\n");
+		trace_nfs_mount_get_root_fhget(sb, server, error);
 		return ERR_CAST(inode);
 	}
 
 	error = nfs_superblock_set_dummy_root(sb, inode);
-	if (error != 0)
+	if (error != 0) {
+		trace_nfs_mount_get_root_dummy_root(sb, server, error);
 		return ERR_PTR(error);
-
+	}
 	/* root dentries normally start off anonymous and get spliced in later
 	 * if the dentry tree reaches them; however if the dentry already
 	 * exists, we'll pick it up at this point and use it as the root
@@ -110,6 +122,7 @@ struct dentry *nfs_get_root(struct super
 	mntroot = d_obtain_alias(inode);
 	if (IS_ERR(mntroot)) {
 		dprintk("nfs_get_root: get root dentry failed\n");
+		trace_nfs_mount_get_root_alias(sb, server, PTR_ERR(mntroot));
 		return mntroot;
 	}
 

  parent reply	other threads:[~2009-01-16 16:27 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 16:22 [RFC][PATCH 0/5] NFS: trace points added to mounting path Steve Dickson
2009-01-16 16:30 ` [PATCH 3/5] NFS: Adding trace points to nfs/client.c Steve Dickson
2009-01-16 16:32 ` [PATCH 4/5] NFS: Convert trace points to trace markers Steve Dickson
2009-01-16 16:33 ` [PATCH 5/5] NFS: Systemtap script Steve Dickson
     [not found] ` <4970B451.4080201-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-01-16 16:25   ` Steve Dickson [this message]
2009-01-16 16:28   ` [PATCH 2/5] NFS: Adding trace points to fs/nfs/super.c Steve Dickson
2009-01-16 18:52   ` [RFC][PATCH 0/5] NFS: trace points added to mounting path Chuck Lever
2009-01-21 17:13     ` Steve Dickson
     [not found]       ` <497757D1.7090908-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-01-21 18:01         ` Chuck Lever
2009-01-21 19:29           ` Trond Myklebust
2009-01-21 19:58             ` Steve Dickson
2009-01-21 20:23               ` Trond Myklebust
2009-01-22 13:07                 ` Steve Dickson
     [not found]                   ` <49786F9F.7030400-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-01-22 15:30                     ` Trond Myklebust
2009-01-22 15:49                       ` Steve Dickson
2009-01-22 17:47                         ` Arnaldo Carvalho de Melo
2009-01-21 19:37           ` Steve Dickson
2009-01-21 20:19             ` Chuck Lever
2009-01-21 22:36               ` Greg Banks
     [not found]                 ` <4977A385.8000406-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2009-01-21 22:47                   ` Arnaldo Carvalho de Melo
2009-01-21 22:57                     ` Trond Myklebust
2009-01-21 23:06                       ` Arnaldo Carvalho de Melo
2009-01-21 22:56                   ` Trond Myklebust
2009-01-21 23:11                     ` Greg Banks
2009-01-21 23:47                       ` Trond Myklebust
2009-01-22  0:53                         ` Frank Ch. Eigler
2009-01-22  2:04                         ` Greg Banks
     [not found]                           ` <4977D431.1020906-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2009-01-22 15:27                             ` Steve Dickson
     [not found]                               ` <49789073.1080200-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-01-22 22:43                                 ` Greg Banks
2009-01-21 22:56                   ` J. Bruce Fields
2009-01-21 23:05                     ` Muntz, Daniel
2009-01-22 15:59                     ` Steve Dickson
2009-01-22 16:45                       ` J. Bruce Fields
2009-01-22 22:54                         ` Greg Banks
     [not found]                           ` <4978F91C.4090208-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2009-01-23 18:09                             ` J. Bruce Fields
2009-01-23 22:18                               ` Greg Banks
2009-01-23 18:17                     ` Chuck Lever
2009-01-22 13:55               ` Steve Dickson
2009-01-22 22:31                 ` Greg Banks
2009-01-21 21:26           ` Greg Banks
2009-01-22 15:19             ` Steve Dickson
2009-01-23 18:28               ` Chuck Lever
2009-01-23 22:21                 ` Greg Banks
2009-01-16 23:44   ` Greg Banks
     [not found]     ` <49711BDF.3010605-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2009-01-17 16:15       ` Frank Ch. Eigler
     [not found]         ` <4972A8F5.7070806@opengridcomputing.com>
2009-01-18 17:47           ` Frank Ch. Eigler
     [not found]         ` <y0mmydpucww.fsf-vo4H8ooykKW2oG+2xah3EoGKTjYczspe@public.gmane.org>
2009-01-18 23:12           ` Greg Banks
     [not found]             ` <4973B777.2000102-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2009-01-19 15:41               ` Frank Ch. Eigler
2009-01-19 23:13                 ` Greg Banks
2009-01-19 14:27       ` Jeff Moyer
     [not found]         ` <x49ab9ntlpp.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2009-01-19 19:49           ` Jason Baron
2009-01-19 22:58             ` Greg Banks
2009-01-21 10:13           ` K.Prasad
2009-01-21 16:39             ` Steve Dickson
     [not found]               ` <49774FDC.5090307-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-01-21 17:04                 ` Arnaldo Carvalho de Melo
2009-01-21 19:59                   ` Steve Dickson
     [not found]                   ` <20090121170401.GD4394-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-01-21 20:39                     ` Christoph Hellwig
2009-01-18 16:40   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4970B4FD.4000400@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=systemtap@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.